Closed (fixed)
Project:
Address Field
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
11 Jan 2011 at 16:04 UTC
Updated:
5 Jun 2012 at 11:33 UTC
Jump to comment: Most recent file
Comments
Comment #1
Ooxo commentedagreed
Comment #2
tema commentedIt appears to be easy. Tested.
Comment #3
Ooxo commentedBrilliant it works like a charm, many thanks Tema
Comment #4
gausarts commentedWould love to see this committed. Thanks
Comment #5
muschpusch commented+1 for committing this
Comment #6
twistor commentedAdded multi-value support and descriptions.
Comment #7
rickmanelius commentedTesting #6. The fields appear to import and display, but are not appearing on the edit screen... will keep testing and see if it's a goof on my end.
I haven't tested #2 yet.
Comment #8
rickmanelius commentedBoth of these patches (#2/#6) definitely get the data in. But when you go to node/[nid]/edit, there is nothing there. If you edit again with new data, it works from that point on. Trying to figure out what the disconnect is... I'm using Drupal 7.2 and the 7.x-1.0-alpha2 for address field.
Comment #9
rickmanelius commentedIt appears that these patches are in fact working as expected, but there is another bug that's preventing using the node edit form in general.
#1094138: Create a watchdog error message when an address field value is saved without a country.
PS. The patch in #6 has a dpm() call that will need to be commented out. Otherwise it works as expected, with the above linked bug to be fixed later.
I've attached another version of the patch with dpm commented out.
Comment #10
rickmanelius commentedProblem found. Patch #6 worked perfectly, you just have to specify a country. Otherwise, these values don't get properly loaded by the node/edit form even though they are clearly in the back end.
So to recap. I merely commented out the dpm line in #6. I've tested and proven that I can import title, first, last, street, city, country, state, zip and it works beautifully.
Marking this reviewed by community and hoping for an accepted patch into the main module.
Comment #11
damien tournoud commentedCommitted a patch based on this. I just moved the hooks to a separate
addressfield.feeds.incfile and removed reference to the XML columns that are now gone.Comment #12
Bevan commentedThe files are not being exposed to Feeds. Using latest Dev release (which contains
addressfield.feeds.inc) the address fields are not exposed as Feeds targets. Using 1.0-beta1 with the patch from comment #9, the address fields are exposed.I think Feeds does not take responsibility for including
MODULE.feeds.incfiles. Whose responsibility is it to include them?Comment #13
Bevan commentedI noticed that
addressfield.feeds.incis included when actually running an import, but not when building source-to-target-maps.Comment #14
johnvBevan, can you try this?
Comment #15
damien tournoud commentedIf anything, this sounds like a bug in Feeds. I'm not going to commit anything specific to feeds to the .module.
Comment #16
damien tournoud commentedSupport for "feeds hooks to be located in modulename.feeds.inc" has been added to feeds in 7.x-2.x-alpha4 (see #381131b). If it doesn't work as expected, please open an issue in the Feeds queue.
Comment #17
13rac1 commentedLink for "feeds hooks to be located in modulename.feeds.inc" is http://drupal.org/node/1203240
Comment #18
13rac1 commentedIssue opened in the Feeds queue, includes patch to correct: http://drupal.org/node/1224836
Comment #20
franzJust a notice here. Don't use module_exists() there, it's not needed since it's a workaround patch, and if addressfield is bootstraped before feeds, it doesn't work.
Comment #21
star-szrImporting works with Feeds 7.x-2.x-dev, they have patched the modulename.feeds.inc issue.
Comment #22
johnvbetter title
Comment #23
dgastudio commentedi have found only one problem...
to import, i have to country code instead of country name.
i mean, instead of SPAIN i have to use SP.
Comment #24
johnv@kervi, Can you use "Feeds Tamper" to change the countries beforehand?
Comment #25
dgastudio commentedno, but i have already solved the problem using patch provided in #1365216: Provide Feeds Tamper plugins to use default values for missing data, map country names to codes, etc.