Closed (fixed)
Project:
Libraries API
Version:
7.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Reporter:
Created:
12 Jan 2011 at 10:25 UTC
Updated:
27 Jan 2011 at 01:20 UTC
Jump to comment: Most recent file
Drupal 7.x change the global variable $profile so the original code for libraries_get_libraries() no longer functioning. On the other hand, Drupal 7.x introduce the new function drupal_get_profile() which will also works during installation.
Patch via libraries-7.x-1.x-dev CVS. Tested with activate htmlpurifier during installation.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | libraries-7.x-1.x-1294853001.patch | 1.42 KB | hswong3i |
| #1 | drupal_get_profile.patch | 1.38 KB | tstoeckler |
| libraries-7.x-1.x-1294827667.patch | 1.05 KB | hswong3i |
Comments
Comment #1
tstoeckler@hswong3i: Thanks for the patch.
There is one other place in the code where we need to determine the profile and I changed that as well.
Comment #2
tstoecklerJust a note that I will commit this tomorrow or the day after in case there are no objections.
It's a correct fix. I'll try to reproduce this bug and the fix, but in this case I don't think that's strictly necessary.
Comment #3
hswong3i commented@tstoeckler: Oh great catch :D
On the other hand, IMHO the use of drupal_get_profile() is now similar as that of conf_path(), so additional dummy comment message shouldn't be required. Just a bit more coding style clean up as your reference.
Comment #4
tstoecklerFine with me. Back to RTBC. (Now I can even legally do that, since it's not my patch :) )
Comment #5
sunThanks for reporting, reviewing, and testing! Committed to HEAD.
A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.