As I was reviewing all the variables, I noticed this one:

spam_blacklist_ip

It only appears in a variable_get() in the Duplicate filter:

$arguments = array(variable_get('spam_threshold', SPAM_DEFAULT_THRESHOLD), variable_get('spam_blacklist_ip', SPAM_FILTER_DUPLICATE_DEFAULT_BLACKLIST));

There is no UI to set the variable. (There is actually no other place where it appears from what I can see.)

If it is expected, it should be documented because at this point I would imagine that no one knows it exists and thus no one does anything with it.

Thank you.
Alexis Wilke

CommentFileSizeAuthor
#2 spam-6.x-old_backlist_variable.patch1.05 KBAlexisWilke

Comments

gnassar’s picture

gnassar commented
Title: Blacklist IP variable? » Blacklist IP variable misnamed
Category: task » bug

SPAM_FILTER_DUPLICATE_DEFAULT_BLACKLIST as the default value should've been the giveaway here. Did you notice where else that was used as a default?

For example, line 88:

if ($spam_filter_duplicate_ip >= variable_get('spam_filter_duplicate_blacklist', SPAM_FILTER_DUPLICATE_DEFAULT_BLACKLIST)) {

Pretty much the same everywhere else you see that constant. The line you found obviously must be an old variable that didn't get changed, probably from a very old pre-5.x-3.x change. 'spam_blacklist_ip' should be 'spam_filter_duplicate_blacklist'.

AlexisWilke’s picture

AlexisWilke commented
Status: Active » Needs review
StatusFileSize
new spam-6.x-old_backlist_variable.patch1.05 KB

At least I found something... 8-)

There is a patch for this one.

Thank you.
Alexis

gnassar’s picture

gnassar commented
Status: Needs review » Reviewed & tested by the community
AlexisWilke’s picture

AlexisWilke commented
Status: Reviewed & tested by the community » Fixed

Thank you.
http://drupal.org/cvs?commit=485976

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.