The "Manual updates required" table in admin/modules/update has an extra (empty) column. See the attached image.

Comments

bfroehle’s picture

Status: Active » Needs review
StatusFileSize
new2 KB
new66.26 KB

The extra column is coming from the '#attributes' attribute. I've added some code which converts the data from a theme_tableselect to a theme_table compatible format. Once nice perk is that we can now keep and use the '#weight' field.

bfroehle’s picture

+++ modules/update/update.manager.incundefined
@@ -244,11 +238,27 @@ function update_manager_update_form($form, $form_state = array(), $context) {
+      if (isset($row['data']['#weight'])) {
+        unset($row['data']['#weight']);

unset shouldn't complain if '#weight' isn't set, right.. so we could just remove the if statement...

Powered by Dreditor.

bfroehle’s picture

+++ modules/update/update.manager.incundefined
@@ -244,11 +238,27 @@ function update_manager_update_form($form, $form_state = array(), $context) {
+      $row['data']= $projects['manual'][$key];

missing a space before the = sign.

Powered by Dreditor.

bfroehle’s picture

Status: Needs review » Needs work
bfroehle’s picture

Status: Needs work » Needs review
StatusFileSize
new2.27 KB

A cleaned up version of the patch in #1. See the images in the original post and #1 for more info.

bfroehle’s picture

Version: 7.x-dev » 8.x-dev
Issue tags: +Needs backport to D7
bfroehle’s picture

Just marked #1118404: "Manual updates required" table broken as a duplicate. In particular, the patch in #1118404-1: "Manual updates required" table broken is simpler (but also pretty ugly).

bfroehle’s picture

Status: Needs review » Closed (duplicate)

Let's just to with the patch in #1118404-1: "Manual updates required" table broken. Markign this as duplicate.