As per title, BM adds the customize tabs to all book type nodes, whether or not they are in a book. You then get the "This node is not in a personal book. " error.

Comments

jgraham’s picture

jgraham commented
Status: Active » Fixed

kenianbei, thanks for the bug report, this has been fixed in the development branch.

jshorb’s picture

jshorb commented
Status: Fixed » Needs work

jgraham -

Where did this get 'fixed'? I just upgraded to the development branch and found that the "Customize" button has disappeared from all of my books. I'm wondering if it has to do with how it checks for whether a node is in a book (perhaps taking into account personal books?).

Logged in as the admin - I should probably see the button on all personal books. However, I see it on none of them. I also don't see the option when logged in as a regular user (even when visiting my own books). I'd be happy to track this behavior down tomorrow and submit it. We do miss the Customize button, but like the batch API very much!

jgraham’s picture

jgraham commented
Status: Needs work » Postponed (maintainer needs more info)

jshorb,

The commit is here

The logic for the customize tab has been changed as follows;

  • if the node type is allowed to be in a book
  • if the node is in a personal book
  • if the node is being viewed by the author

If the above conditions are met the customize tab should show up. Otherwise it is assumed that either the user should not be allowed to use book managers customize, or they should be granted access to core book's outline feature.

If you are not experiencing the above behavior please post details on how to reproduce the issue as I am unable to reproduce this behavior.

jshorb’s picture

jshorb commented
Status: Postponed (maintainer needs more info) » Closed (works as designed)

jgraham -

I believe this is working as expected, then. A collaborator had accidentally moved some pages from a common book (not checked 'personal') into their personal book. This "broke" the personal book status - and unmade the entire book to be not personal. I hope that makes sense. Thus:he Customize button disappeared because the book had spontaneously become not personal.

The Customize button does work as you describe. I'm just shocked that the admin shouldn't be allowed to use the customize feature for books that are not their own. I currently have only one other user of the site and I've already had to go in and fix some minor problems that were simply part of the learning process. I would suggest that the customize button be a user-permission:

  • Customize any personal book
  • Customize own personal book

So that the first permission can be granted to certain user-groups (such as admin). Ideally - I don't see why the Customize button couldn't be on all books for the admin group - but I can see how that's redundant. After all, admins can do the customize features ourselves through other interfaces. I do have to say that I really enjoy using the interface this module provides, though!

Moving this to works as designed. I'll add a post with a link to a feature request after I mull over how that would work best. Thanks!