facebook connect login broken

Facebook Connect must be correctly configured and working before enabling OpenID Selector submodule, i.e.:
a) disable OpenID Selector for Facebook Connect,
b) make sure Facebook Connect "Login with Facebook" button works
c) enable OpenID Selector for Facebook Connect

Hi,
I have the same issues with the facebook connect.

The fb connect button it's work fine but when activate (OpenID Selector for Facebook (Platform)) module and click on the facebook login nothing happened.

i make all step above but nothing change.

Hi all,

Not any one help me

Subscribing, Facebook doesn't work in 6-dev

I had to use the work around I listed here:

http://drupal.stackexchange.com/questions/4524/facebook-openid-selector/...

This also effects Drupal 7 and the 7.x-1.x-dev (2011-May-07) version.

I've created a patch which fixes the issue for me (as I outlined above on the stack exchange article) but hopefully this will make it easier to fix in the repository.

sub

I don't understand the entire patch, but I notice you're hiding the fb_user.module facebook connect button. You can instead just configure that module not to render the button. See admin/build/fb/fb_user.

I didn't add the code that hides it. That logic was already there. What was broken was that the dom id's had changed and so the existing code was trying to work on null objects.

I made the smallest change I could as I'm not very familiar with drupal and module code yet.

We also have the issue with the openid selector facebook button it has issues when using on a mobile site and I think it may be a javascript related issue but cannot figure it out.

I noticed if we changed the cookie domain in setting.php to .ourdomain.com it works again

I guess I spoke to soon, the button does not go anywhere when actually on a mobile device was testing with a user agent.
This is for facebook connect on stable build 6 does not work on mobile devices. Only desktops. Regular rendering of facebook connect works fine. Also tried changing weight but no luck.

I don't understand the entire patch, but I notice you're hiding the fb_user.module facebook connect button. You can instead just configure that module not to render the button. See admin/build/fb/fb_user.

Just fyi, the button needs to be rendered in order for the javascript to simulate a click of it. If you you set it up not to render, it will not work.

Hi, I have the same issues with the facebook connect. When user click on the facebook login nothing happened.
(latest modules - Drupal for Facebook 6.x-3.2-rc5+2-dev, Openid selector 6.x-1.x-dev)

I just installed all this using Drupal for Facebook 6.x-3.3 with the Facebook SDK 3.1.1 and the latest version of OpenId Selector, and it worked fine (solved the problem I had with this previously)

Work was being duplicated at #1350732: OpenID Selector for Facebook (Platform) does not do anything.. Justin (who I see is on this thread also) had posted this patch there. The significant difference is the selector used in these two blocks. In the other issue, it was reported that the patch there (second below) did not work on the login block - possibly the looser selector from #6 is the one we want.

#1025038-9: facebook connect login broken

+++ openid_selector/openid_selector_fb.js	2011-09-16 11:14:02.178544925 -0500
@@ -13,7 +13,7 @@
-  url: "javascript: $('.fb-login-button a').click();"
+  url: "javascript: $('.fb_button').click();"

#1350732-6: OpenID Selector for Facebook (Platform) does not do anything.

@@ -13,7 +13,7 @@ delete providers_large[replace_id];
-  url: "javascript: $('.fb-login-button a').click();"
+  url: "javascript: $('.fb_user-login-button-wrapper a').click();"

I take it all back - it worked when I tested it, and now it doesn't any more! If I have time I might try out some of these patches...

IDK if we need to magically click the button, I think we can just FB.login() directly?

--- a/openid_selector_fb.js
+++ b/openid_selector_fb.js
@@ -13,7 +13,7 @@ delete providers_large[replace_id];
 
 providers_large.facebook = {
   name: 'Facebook',
-  url: "javascript: $('.fb-login-button a').click();"
+  url: "javascript: FB.login();"
 };
 

Dropping this here, will attach a proper patch if this tests out OK.

fixed for D6 in http://drupalcode.org/project/openid_selector.git/commit/b9e9405

How fixed ?

Thanks Andriy. Great to see you back.

If you're going to be actively maintaining OpenID Selector again, please add a response to #1673150: Is OpenID Selector still being maintained? and let us know if you are open to co-maintainers helping you out.

ok

fixed for D7 in http://drupalcode.org/project/openid_selector.git/commit/4cf30bb