Hi,

first... thank you for this great module. I have integrated the "Colorbox"-Plugin (http://colorpowered.com/colorbox/) on one of my sites and I want to ask, how I should attach the code for this integration to get it integrated into a release of this module?

I can provide a zip or tar.gz with the code for the first check. Currently I'm using the 6.x-2.9 release.

Best regards, Tom

CommentFileSizeAuthor
#4 wysiwyg_imageupload_colorbox.tar_.gz2.26 KBTomMynd

Comments

eugenmayer’s picture

eugenmayer commented

Well as the integratino for shadowbox, lightbox and the others, the integration for colorbox will become a submodule on its own. So all you need is kind of copy the lightbox module and then change those strings - thats it. Tar-gz the submodule and upload it here or give me a link to a github repo.

Thanks for the contribution!

TomMynd’s picture

TomMynd commented

Hi,

I already have a working submodule, so that should by fine. I will look through the code again and will upload it later this day.

Best regards, Tom

eugenmayer’s picture

eugenmayer commented

That sounds perfect. Just use "coder" to be sure the formating is right.

TomMynd’s picture

TomMynd commented
StatusFileSize
new wysiwyg_imageupload_colorbox.tar_.gz2.26 KB

Hi,

it was more than a search/replace but it worked out of the box for me. So it was not a big thing.

I also checked the code with coder and there were no problems found.

Please see the attached file. Unpack it inside the modules-folder of wysiwyg_imageupload. You also have to enable the colorbox-module... :-) But this is marked as an dependency inside the info-file.

Best regards, Tom

TomMynd’s picture

TomMynd commented
Status: Active » Needs review
eugenmayer’s picture

eugenmayer commented

Looks good. i will have a look at it before the 2.10 release. Thank you a lot!

eugenmayer’s picture

eugenmayer commented
Status: Needs review » Fixed

added to the master

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.