I would like to request a feature where if ANY user manually adds a web feed, and another user wants to add feeds to his/her mysite, it should display in the list of available feeds.

I have noticed that if one user adds a feed called let's say "digg" and the other user types "dig" in the feed name field, it will autocomplete, and user 2 can use the digg feed.... but I want them listed too.

Otherwise maybe an option where the admin can periodically go into the feeds and decide which ones should be publicly listed.

Thanks!

Comments

agentrickard’s picture

There are two issues here:

1) I have noticed that if one user adds a feed called let's say "digg" and the other user types "dig" in the feed name field, it will autocomplete, and user 2 can use the digg feed.... but I want them listed too.

All feeds should be listed, but.... for UI reasons, only the first 10 are shown (sorted alphabetically). If you have more than 10 feeds, they are all present, just 'hiddden.' That's why search is there. Until we have AJAX-sortable tables, I don't see a fix for this. However, if you enable the MySite block, navigating to a feed page will show an 'add this feed' link.

You could also adjust the FEED_THRESHOLD constant in feed.inc to a value higher than 10. This would show more than the 10 items in the table view.

2) This is a good solution to the 'only show 10 feeds problem' and might be implemented in the 5.x branch. If you want to do it for your site in 4.7, you could, if you read the API carefully.

agentrickard’s picture

Status: Active » Closed (works as designed)
jacauc’s picture

Status: Closed (works as designed) » Active

All feeds should be listed, but.... for UI reasons, only the first 10 are shown (sorted alphabetically). If you have more than 10 feeds, they are all present, just 'hiddden.'

I have 3 predefined feeds which I defined as the admin. These are the only 3 feeds visible to users. Other feeds can be added with the "dig" type search. But the only feeds displayed (in drupal 5.x) are the 3 feeds defined as an admin under aggregator settings

agentrickard’s picture

Assigned: Unassigned » agentrickard
Category: feature » support

Are the user-submitted feeds assigned to a category? If not, I don't believe they will appear in the options list.

The design assumption is that all feeds are stored within an Aggregator category.

Look at mysite_type_feed_options()

  // get the categories
  $sql = "SELECT cid, title FROM {aggregator_category}";
  $result = db_query($sql);
  while ($cat = db_fetch_object($result)) {
    $sql = "SELECT a.fid, a.title FROM {aggregator_feed} a INNER JOIN {aggregator_category_feed} c ON a.fid = c.fid WHERE c.cid = %d";
    $new_result = db_query_range($sql, $cat->cid, FEED_FROM, FEED_THRESHOLD);
    while($item = db_fetch_object($new_result)) {
      $feeds[$cat->title][] = $item;
    }
  }

Under that logic, uncategorized feeds will not appear in the table.

But in mysite_type_feed_search_form_submit(), the code doesn't care about categories.

  $result = db_query("SELECT fid, title, description FROM {aggregator_feed} WHERE title LIKE LOWER('%s%%')", $form_values['feed_title']);

Do you have default categories defined for user-submitted feeds, as described in the help, and available here?

http://example.com/?q=admin/settings/mysite/type/feed

agentrickard’s picture

Status: Active » Closed (works as designed)

Marking 'by design' since no followup.