Link is to
index.php?q=sites/all/modules/taxonews/INSTALL.txt
which gave me a page not found in my site log.

My site is in a subdirectory, and we do not have clean URLS, if that is relevant, but the path is not valid with or without clean URLs.

CommentFileSizeAuthor
#12 unclean-urls-1025524-12.patch1.94 KBfgm
#10 unclean-urls-1025524-10.patch1.4 KBfgm
#4 taxonews_1025524_3.patch5.55 KBfgm
#3 taxonews_1025524_1.patch2.35 KBfgm
#2 taxonews_1025524.patch1.75 KBfgm

Comments

fgm’s picture

fgm
Primary language French
Location Paris, France
commented

Good catch: I did not test without clean URLs. The link should be sites/all/modules/taxonews/INSTALL.txt whether clean URLs are there or not. D7 has a mechanism in url() for this (the "script" option), but not D6.

OTOH, it seems you saying the link does not work when clean URLs are on, although it should work in that case. Can you confirm ?

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Active » Needs work
StatusFileSize
new taxonews_1025524.patch1.75 KB

Got a patch to catch it during testing. On to the fix itself, now.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
StatusFileSize
new taxonews_1025524_1.patch2.35 KB

Actually, because of Simpletest issue #1027210: DrupalWebTestCase::clickLink() can be wrong, the test is a bit more involved.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Needs work » Needs review
StatusFileSize
new taxonews_1025524_3.patch5.55 KB

Ths patch below has been committed to the dev branch.

Can you either test with this patcha applied or just checkout the dev version when it gets rerolled to see if this fixes your case too ?

verta’s picture

verta commented

Thanks for the patch, will try the -dev, having trouble getting the patch applied.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented

That must be because the patch applies to the 6.x-1.x-dev version. You should be using it, as it contains numerous fixes and improvements over 6.1.0.

Status: Needs review » Needs work

The last submitted patch, taxonews_1025524_3.patch, failed testing.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Version: 6.x-1.0 » 6.x-1.x-dev
Status: Needs work » Needs review

Patch bot is now live: this patch applies to 6.x-1.x-dev, setting accordingly.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Needs review » Postponed (maintainer needs more info)

Errr... no it will no longer apply since it has already been committed. Just do a test with the dev version which was rolled last night. Let's forget the bot for now.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new unclean-urls-1025524-10.patch1.4 KB

Test catches the error on 7.x

Status: Needs review » Needs work

The last submitted patch, unclean-urls-1025524-10.patch, failed testing.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Needs work » Needs review
StatusFileSize
new unclean-urls-1025524-12.patch1.94 KB

Fixed as per #1009120: url() fails on files without clean URLs.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Issue summary: View changes
Status: Needs review » Fixed

Was actually fixed 3 years ago in (CVS-style) version 1.10.8.20.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.