I am using the Panel fields row style in some Views displays, and after upgrading to 3.9 I'm seeing empty fields in these displays. The rows themselves are in fact displayed, but they have no field content when output to the page in question. This is also true in the live preview when editing the View. Switching to another row style remedies this problem.
The views in question all use 1 argument, some filters, sort options and a couple of relationships.
I have compared the generated SQL from 3.8 to 3.9 and cannot detect a difference, but I guess that is expected behaviour. Running the query by hand does in fact provide a node_title column containing the title of the nodes, but it is not output to Views (when using Panels 3.9).
Reverting to Panels 3.8 correctly displays the Views that use Panel fields.
To be clear: I'm using the Views UI, but this bug pertains specifically to Panel fields which are maintined in the Panels module.
Setup:
Drupal 6.20
Views 3.x-dev
CTools 1.8
Panels 3.9
Comment | File | Size | Author |
---|---|---|---|
#14 | 1025716-broke-empty-fields.patch | 2.05 KB | merlinofchaos |
#11 | 1025716-broke-empty-fields.patch | 1.58 KB | merlinofchaos |
Comments
Comment #1
robbt CreditAttribution: robbt commentedI noticed the same thing upon upgrading to Panels 3.9
All of my panel fields were displaying as if they had no content, but then switching to fields displayed them properly.
Comment #2
scottkrieger CreditAttribution: scottkrieger commentedsame as #1 here.
Comment #3
shrimphead CreditAttribution: shrimphead commentedSame here.
Downgrading to3.8 solves it but doesn't resolve the security issue.
Comment #4
rteuber CreditAttribution: rteuber commentedSame here
Comment #5
plenarius CreditAttribution: plenarius commentedSeems to be related to the patch that closed #964334: Style Unformatted requires a row style but the row plugin is invalid . Reverting the changes that were applied in the patch listed there in comment #22 appears to correct this.
Comment #6
achtonWhat is missing might then be the optional parent directive for the hook_views_plugin implementation in plugins/views/panels.views.inc. However, the solution should not re-introduce the bug in #964334: Style Unformatted requires a row style but the row plugin is invalid , and I have no clue how to accomplish that.
EDIT: turns out the above was not the solution at all. See #14.
The Views docs from Advanced help might be able to shed some light on this for someone.
Comment #7
ayukko CreditAttribution: ayukko commentedSubscribe. In my case, the query does not show any record.
Comment #8
thomas73 CreditAttribution: thomas73 commentedMe also. Had to downgrade to 3.8
Comment #9
bryanhidalgo CreditAttribution: bryanhidalgo commentedSame problem here
Comment #10
merlinofchaos CreditAttribution: merlinofchaos commentedThis is on my list of things to look at today.
Comment #11
merlinofchaos CreditAttribution: merlinofchaos commentedTry this. Please let me know if this works.
The initial change there was done to prevent a notice, but then I realized that it actually used that theme function after all.
Note: Must clear cache. Both theme registry and views cache need to be cleared. Your best bet is drush cc all, devel module's clear cache button, or the clear cache on the performance page.
Comment #12
achton@merlin: thanks, I will test this ASAP, but it might take 48 hrs.
But uh .. I think you missed the -u switch when creating the patch? I can read it though, so if you don't care, I don't either.
Comment #13
thomas73 CreditAttribution: thomas73 commentedIt works for me, thanks!
Comment #14
merlinofchaos CreditAttribution: merlinofchaos commentedSo I did! Oh exhaustion, you amplify mistakes.
Here's a proper patch.
Comment #15
achtonPatch works for me too - thanks!
Comment #16
ayukko CreditAttribution: ayukko commentedPatch works for me too! Thanks a lot
Comment #17
zajicew CreditAttribution: zajicew commentedPatch works for me too! Thanks!
Comment #18
Drake CreditAttribution: Drake commentedSolved my issue too... i think this patch shpuld be added imadiately to the newest Panel version because many people updates the modules before checking if such udpate would create any issues...
Comment #19
achtonI think it is safe to RTBC this now.
Comment #20
CSCharabaruk CreditAttribution: CSCharabaruk commentedhttp://drupal.org/node/1031960 is the same problem but for 7.x-3.x, I can confirm the patch in comment 14 works there too.
Comment #21
bennash CreditAttribution: bennash commentedI also had success with the patch in 7.x-3.x
Comment #22
dddbbb CreditAttribution: dddbbb commentedAny idea when this patch might get rolled into dev?
Comment #23
merlinofchaos CreditAttribution: merlinofchaos commentedCommitted to all branches.
This is the first confirmation I've had that people actually use this feature. :)
Comment #24
thomas1977 CreditAttribution: thomas1977 commentedSubscribing - same issue here
Comment #25
dddbbb CreditAttribution: dddbbb commented@merlinofchaos Really? It's really handy.
Comment #26
dddbbb CreditAttribution: dddbbb commentedJust upgraded to 6.x-3.x-dev but I still get the same problem with Panel Fields not displaying.
Anybody else?
Comment #27
dddbbb CreditAttribution: dddbbb commentedForgot to change status. Not sure if I'm allowed to do that. Sorry if not :)
Comment #28
merlinofchaos CreditAttribution: merlinofchaos commentedOh yes, I think it's an awesome feature. It's also still pretty new and I don't know how widely known it is.
When you update, be sure to clear caches; it's in the views data and that's cached.
Comment #29
thomas1977 CreditAttribution: thomas1977 commentedTried latest dev. Still same issue - even after having run "flush all caches".
Comment #30
dddbbb CreditAttribution: dddbbb commentedI cleared caches as soon as I saw no change after updating but that didn't seem to have any effect. Seems like the person above me is also having a similar issue.
I won't touch the status this time but it's not looking too fixed for me at this end.
Comment #31
achtonI have upgraded to latest -dev (from having patched manually before) and things still work fine for me.
#29 and #30, you should triplecheck your update procedure. If you download the -dev package manually and check the contents of the file /plugins/views/panels.views.inc, you'll see that the file has indeed been patched. I would check that file in your installation post-update, and if the file has indeed been patched then you know that your Drupal-installation is somehow caching the old code.
Hope you get it working!
Comment #32
dddbbb CreditAttribution: dddbbb commentedHave checked in /plugins/views/panels.views.inc but I'm not sure what I'm looking for to confirm that it's been patched. My file contains the following code, could someone please confirm that this is the correct, patched code for me?
I have caching disabled and have tried flushing all caches including manually flushing the cache at admin/settings/performance, deleted the browser cache and refreshed the page repeatedly. Still no joy.
Comment #33
merlinofchaos CreditAttribution: merlinofchaos commented'theme'
=> NULL is the old code.Comment #34
merlinofchaos CreditAttribution: merlinofchaos commentedhttp://drupalcode.org/viewvc/drupal/contributions/modules/panels/plugins... is the commit that changed this. The latest -dev that includes this code is dated Jan 24.
Comment #35
dddbbb CreditAttribution: dddbbb commentedI double checked the dates when I downloaded it. I'll try it again (again) to be triple sure before posting anything else.
Thanks for confirming that I'm still running the old code - at least that would go to explain why I'm not seeing any change in display.
Comment #36
dddbbb CreditAttribution: dddbbb commentedDownloaded the new dev version dated 25th Jan and all is now sorted (previous dev version I downloaded was 24th Jan - not sure if that was the cause or not). Thanks for all the help.
Comment #37
merlinofchaos CreditAttribution: merlinofchaos commentedIt's possible you downloaded after I committed but before the -dev was rerolled. drupal.org only rolls new -dev releases at noon and midnight GMT, so there can be a significant delay from the time of commit.
Comment #38
thomas1977 CreditAttribution: thomas1977 commentedSeems like the last dev (Jan. 25) did solve the "blank panel fields" issue. Thanks a lot!
Comment #40
Miko. CreditAttribution: Miko. commentedmerlin, how does one install a patch like this? Is CVS mandatory? I'm hoping I don't have to find, install, learn a CVS client just to install this patch. :(
Comment #41
Dimm CreditAttribution: Dimm commented+1
Comment #42
Adeehadee CreditAttribution: Adeehadee commentedthx !
working fine !
Comment #43
lpalgarvio CreditAttribution: lpalgarvio commented+1
Comment #44
nicholasThompsonAny idea when 6.x-3.10 will be tagged?
Comment #45
asb CreditAttribution: asb commentedComing from #1225896: View with Panels fields embedded in Panel page doesn't display View and looking forward to Panels 6.x-3.10 as well ;)
Comment #46
RaulMuroc CreditAttribution: RaulMuroc commentedHas it been implemented on current 7.x-3.x-dev version?
Comment #47
merlinofchaos CreditAttribution: merlinofchaos commentedYes. Differently because Views changed the proper way to do this since then.
Comment #48
deltab CreditAttribution: deltab commentedThis more than one year old issue is NOT solved completely, there are many oversights on the developer's part, and if one overrides titles in Panels, the module breaks again.
Comment #49
davidwhthomas CreditAttribution: davidwhthomas commented@deltab
Subtle hint, but complaining of oversights on the developer's part is not the best way to get support.
Nevertheless, I'm encountering a similar issue, in my case using the node_view panel and finding empty node fields are now being output as empty panes.
It does appear to be related to using the "Override title" feature.
When override title is off, and the node field is empty, nothing is output, as expected.
When override title is on, and the node field is empty, the pane is still output.
Need to prevent output if empty content, even if override title is on.
Comment #50
deltab CreditAttribution: deltab commented@davidwthomas, I used to offer QA and click testing (all I know how to) two years ago, Drupal developers didn't care in any case, so I know one will never get support.
Now I only register my complaints, and hope some 3rd party developer will contact me and solve the issue for a small fee. I have another long story going on with UUID and node save, if revisions are left on, then UUID changes all the time, rendering the module useless for any practical reason. Do you think they fixed it or even responded to the issues I raised politely?
No.
Workaround for this issue would be,
1. Turn Override Title Off,
2. Install String Overrides or Strongarm, and context
3. Configure to get the job done
Comment #51
deltab CreditAttribution: deltab commentedComment #52
merlinofchaos CreditAttribution: merlinofchaos commenteddeltab: If that is your attitude, I have no interest in your input. There are thousands of people who maintain Drupal modules and the amount of time and energy they have to do their volunteer jobs varies. Treating them poorly helps no one.
davidwhthomas: Hm. Okay, the problem you refer to is actually about empty panes appearing if their title is overridden. That is actually completely unrelated to the issue this is about, which is about the 'panel fields' row style. Could you do me a favor and please post a new issue with the information you have?
Returning this to its previous state.
Comment #53
merlinofchaos CreditAttribution: merlinofchaos commentedActually, thanks to the bug report in #49 I was able to easily reproduce. I created a new issue at #1735216: Field API field content type incorrectly renders if title is overridden but field is empty
Comment #54
merlinofchaos CreditAttribution: merlinofchaos commentedComment #55
lpalgarvio CreditAttribution: lpalgarvio commenteddeltab: no one gets anywhere with that attitude. you should know that good public relations and human resources is the key to any business, project and team, if they are to succeed.
great work merlin =)