we would like to use the station module for an independent radio progect. but we use pretty much exclusively ogg for streaming. the archive modlule doesn`t support any audio format but mp3. streamripper, supports vorbist, so ripping isn´t a problem. its a farily easty hack to get "station_archive.module" to import .oggs, but one imported they are unplayable.

is there any way to get ogg-vorbis support in the station module?

CommentFileSizeAuthor
#10 station_ogg.patch3.35 KBmfb
#5 station.ogg_.patch3.27 KBmfb
#3 station-ogg.tar.gz7.01 KBkevinb-1

Comments

drewish’s picture

i'd be interested in supporting ogg. perhaps you'd post a patch with the changes you had to make? i think the majority of the work would be with the audio module (as you noticed).

drewish’s picture

Version: 4.7.x-1.x-dev » 5.x-2.x-dev

(this would be happen officially in 5.0)

kevinb-1’s picture

StatusFileSize
new7.01 KB

ok here are two patches applied to station_archive.module,v 1.12.2.1 2006/11/21 17:51:29 drewish
station_archive.module-ogg0.diff
station_archive.module-ogg1.diff

"station_archive.module-ogg0.diff" imports oggs, but maintains ".mp3" extenstion. "station_archive.module-ogg1.diff" imports oggs and renames them with extension ".ogg", but these files are not reproducable (playable - in something like xmms for example).

kevinb-1’s picture

hey i said i would publish the site where we are using the station module but never did.
still a work in progress, but here it is:
http://comunaradial.sarava.org/

mfb’s picture

StatusFileSize
new3.27 KB

Here's a patch for support ogg vorbis stream archives.

mfb’s picture

Status: Active » Needs review
drewish’s picture

that looks really good. the only small thing would be in the ripper, i'd like the setting put into a variable first before building the command line.

mfb’s picture

shall i tweak the patch? if so set to code needs work

drewish’s picture

Status: Needs review » Needs work

yeah, couple of things call the setting/variable file_format not file_type. and in _station_archive_add_file() could you see if you could combine the file name as a timestamp and file extention matching into one preg_match? and then assign them to named variables rather than leaving them in the array.

mfb’s picture

Status: Needs work » Needs review
StatusFileSize
new3.35 KB

OK I used explode since there was already a preg_match to get the list of files.

drewish’s picture

Status: Needs review » Fixed

perfect. before committing it i made one change to the comment in the ripper.inc file to quote the allowed values and forced the file_format to lower case when loading it from the settings (since drupal's file scan is case senstive).

Anonymous’s picture

Status: Fixed » Closed (fixed)