META ISSUE

motivation

We removed a lot of $op params, but we left some in.

proposed resolution

We should remove them

Remaining tasks

  • document a grep (or some way) to check for any remaining
  • find out if other existing issues are taking care of some
  • in general evaluate if this issue is still relevant

Comments

karschsp’s picture

karschsp commented

#1281938: Remove $op param from hook_node_access
#765984: Convert hook_openid('request', ...) to hook_openid_request_alter()
#611772: Node access hooks don't quite make sense...

It looks like hook_locale has already been removed.

chertzog’s picture

chertzog
he/him
Primary language English
Location Harrisburg, PA, USA
commented

hook_node_grants and hook_node_grants_alter are being addressed here: #1469758: Define $user in hook_node_grants_alter

yesct’s picture

yesct commented
Issue summary: View changes

getting a first look at if this is still relevant, put issues in the summary.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Version: 9.5.x-dev » 10.1.x-dev
catch’s picture

catch
he/him
Primary language English
commented

#1281938: Remove $op param from hook_node_access is won't fix now, ten years after that was decided in the issue.

hook_node_grants() still has an $op parameter, so needs an issue creating for it.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue summary: View changes

There's function _user_mail_notify($op, AccountInterface $account) which needs work

Looking at node_query_node_access_alter() I see $query->getMetaData('op') which means API change and should use follow-up to rename metadata key with BC

updated IS a bit

andypost’s picture

andypost
he/him
Primary language Russian
commented

There's a bit more

$ git grep '$op,'|grep public
core/lib/Drupal/Core/Config/ConfigImporter.php:352:  public function getUnprocessedConfiguration($op, $collection = StorageInterface::DEFAULT_COLLECTION) {
core/modules/system/src/Controller/DbUpdateController.php:143:  public function handle($op, Request $request) {
core/modules/user/tests/src/Kernel/UserMailNotifyTest.php:83:  public function testUserMailsSent($op, array $mail_keys) {
core/modules/views_ui/src/Controller/ViewsUIController.php:159:  public function ajaxOperation(ViewEntityInterface $view, $op, Request $request) {
core/tests/Drupal/Tests/Core/Access/AccessResultTest.php:858:  public function testAndOrCacheabilityPropagation(AccessResultInterface $first, $op, AccessResultInterface $second, $implements_cacheable_dependency_interface, $is_cacheable) {

And

$ git grep '$op)'|grep public
composer/Plugin/Scaffold/ScaffoldFileInfo.php:43:  public function __construct(ScaffoldFilePath $destination, OperationInterface $op) {
core/modules/block/src/Controller/BlockController.php:54:  public function performOperation(BlockInterface $block, $op) {
core/modules/content_translation/src/ContentTranslationHandler.php:287:  public function getTranslationAccess(EntityInterface $entity, $op) {
core/modules/content_translation/src/ContentTranslationHandlerInterface.php:38:  public function getTranslationAccess(EntityInterface $entity, $op);
core/modules/search/src/Controller/SearchController.php:205:  public function performOperation(SearchPageInterface $search_page, $op) {
andypost’s picture

andypost
he/him
Primary language Russian
commented

Filed new child - #3353545: Rename $op to $operation arguments

andypost’s picture

andypost
he/him
Primary language Russian
commented

There only one child left and change record looks unrelated

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#3380781: Rename $op with BC usage in update.php

Filed new child #3380781: Rename $op with BC usage in update.php

ankitsingh0188’s picture

ankitsingh0188
he/him
Primary language English
Location Pune
commented
Status: Active » Needs review

Please review the child issue https://www.drupal.org/project/drupal/issues/3380781

smustgrave’s picture

smustgrave commented
Status: Needs review » Active

This is a meta with open issues

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.