When I enable "Aggregate and compress CSS files" with Garland as the default theme, the background images disappear in IE7 and IE6 (tested by Chriskennedy). The layout is still fine on Opera 9.02.

Without the preprocessor enabled, Garland displays as it should.

(Apache/2.2.2 (Win32), PHP/5.1.4)

CommentFileSizeAuthor
#10 css_parentheses_whitespace.patch968 bytesSteven
#6 css_whitespace_0.patch734 bytesChrisKennedy
#4 css_whitespace.patch686 bytesChrisKennedy
#1 css_keepwhitespace.patch892 bytesChrisKennedy
CropperCapture[8].Png49.02 KBheine

Comments

ChrisKennedy’s picture

ChrisKennedy commented
Status: Active » Needs review
StatusFileSize
new css_keepwhitespace.patch892 bytes

Taking out the whitespace optimizations appears to fix this bug and http://drupal.org/node/102487

Patch attached, tested in IE6.

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

I believe this is good to go. While it is a regression, no user interface or API is affected so we can fix this post RC without affecting anything/anyone. (Once again, IE rains the parade :( how sad.)

chx’s picture

chx commented

And, even if we can/do not fix this past RC, we can ship D5 without the whitespace removal in core. It would be not as perfect but nothing is :(

ChrisKennedy’s picture

ChrisKennedy commented
StatusFileSize
new css_whitespace.patch686 bytes

Attached patch fixes both issues by removing the first regex substitution but keeps the second two.

m3avrck’s picture

m3avrck commented

I bet this is a problem with @import -- unfort I don't have anytime to verify, but with a quick glance that is my best guess. Steven could probably comment more, that was his regex :-p

ChrisKennedy’s picture

ChrisKennedy commented
StatusFileSize
new css_whitespace_0.patch734 bytes

It turned out that the \) was causing the error. This patch uses chx's suggestion to just str_replace an extra space after parentheses.

heine’s picture

heine commented

Solves the issue on IE7

heine’s picture

heine commented

#6 solves the issue on IE7 and has no negative consequences for Opera.

jacauc’s picture

jacauc commented

worked for me. see http://drupal.org/node/102487

Steven’s picture

Steven commented
StatusFileSize
new css_parentheses_whitespace.patch968 bytes

Patch attached which leaves a single space around parentheses, but still strips on the inside. I also added the comma as a separator.

Steven’s picture

Steven commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD after IRC approval.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)