Sorry Aaron, but the 'fix' did not work.

I still get http://mysite.dk/Array - Page not found. Your - otherwise great - module is making my site in-operable.

I get:
* warning: Illegal offset type in isset or empty in /home/xxxx/public_html/includes/path.inc on line 65.
* warning: Illegal offset type in /home/xxxx/public_html/includes/path.inc on line 70.

So once again I will downgrade (don't know what is wrong with version 6.25 anyway).

Comments

Skizzo-1’s picture

Exact same issue, and also downgraded to V 2.5. Awaiting developments on this matter.

dmjossel’s picture

Same here. All page titles now appended with /Array. Downgrading.

PixelClever’s picture

Status: Active » Postponed (maintainer needs more info)

Why did you open a new issue for this denko? When you write "the 'fix' did not work" this tells me this is tied to something in the past, but I shouldn't have to go search through the issue queue to decode what you are talking about. This issue description doesn't make sense isolated here, and the steps to reproduce it are not mentioned. I am running this module on my site and this error has never shown up, so you are going to have to be more specific.

PixelClever’s picture

If you try changing
$alias = drupal_lookup_path('alias', $link['path'], $lang); to
$alias = drupal_lookup_path('alias', $link['path'], $prefix); on line 183 does the issue go away?
If it does then I will update the module, otherwise I will wait until someone can provide the exact conditions which set off the error.

Skizzo-1’s picture

Hi Aaron,

I guess Denko chose to do it this way, because the issue 'URL Redirection' (http://drupal.org/node/1024676) is marked 'fixed/closed'. It took me some time to find out the problem was related to this module, so I described the issue somewhere else too (http://drupal.org/node/925286). Sorry for the inconvenience.

Anyway, here are my findings:

The warning I get is:
* warning: Illegal offset type in isset or empty in /home/xxxx/public_html/includes/path.inc on line 65.
* warning: Illegal offset type in /home/xxxx/public_html/includes/path.inc on line 70.

Lines mentioned contain:
line 65: if (isset($map[$path_language][$path])) {
line 70: $map[$path_language][$path] = $alias;

Warning appears when entering the website. While loading the URL changes to http://www.xxx.nl/nl/Array, which leads to a 'page not found' and the warning.

Aaron, I'll try the fix and let you know.
Kind regards,
Marion

alexweber’s picture

Just for the record I'm getting this too:

Warning: Illegal offset type em _drupal_lookup_path_direct() (linha 115 em /home/alex/Projects/aw/includes/path.inc)

warning: Illegal offset type in isset or empty in /home/alex/Projects/aw/includes/path.inc on line 65.
warning: Illegal offset type in /home/alex/Projects/aw/includes/path.inc on line 70.

Skizzo-1’s picture

Tried the patch described at #4. Unfortunately it didn't do the trick.

alexweber’s picture

There is no way to accurately replicate this as far as I can tell. If you navigate around it seems to show up randomly but is definitely related to the module as disabling it does the trick.

This is critical because it breaks navigation.

Egmund’s picture

Status: Postponed (maintainer needs more info) » Active

Sorry Aaron, but (as mentioned) the issue was "fixed closed" AND this is a new version.

Since I - apparently mistakenly - thought the update was related to this issue I 'merely' did it this way.

I am not going to look into your code, since I do not have the problem with 6.25, but I am using i18, my site is two-language: English and Danish, there are four 'ways' to get to my site, among those are egelykloster.dk which gives the problem, taikyoji.dk which was OK. So I assume the problem have something to do with alias domains.

Good luck
Denko

wadmiraal’s picture

+1

When updating to 6.x-3.1, all absolute urls redirect to /Array. This means that, in my case, all menu links work just fine (relative paths), but if you type any url (even just the domain name) in the address bar of your browser, it redirects to /Array.

Deactivated several modules, downgraded some, downgraded Drupal core, etc. Conclusion: the issue is definitely coming from your module.

Downgraded to 6.x-2.5 for now, which works.

PixelClever’s picture

Status: Active » Closed (fixed)

I finally figured out what you guys were talking about. It was the automatic redirection to the last viewed language. That was still using the return value from the old code. Anyway it is fixed in 3.2

dmjossel’s picture

Status: Closed (fixed) » Active

This is still present in 3.2. When I arrive at http://sitename.net the site immediately appends /Array to the end, resulting in a page error. Clicking on a link makes it go away, but if you close the window and type in the URL again, /Array is appended again. Happens in any browser.

Downgrading to 2.5 again.

dmjossel’s picture

Version: 6.x-3.1 » 6.x-3.2

Changing to 3.2.

PixelClever’s picture

Status: Active » Closed (fixed)

I just downloaded it and looked at the code. The change I made didn't get committed for some reason. Recommitted as 3.3.

dmjossel’s picture

Version: 6.x-3.2 » 6.x-3.3
Status: Closed (fixed) » Active

Just updated to 3.3. No change.

languageinterface.module for 3.2 and 3.3 appear to be identical.

// $Id: languageinterface.module,v 1.18 2011/01/13 21:48:54 aaronhawkins Exp $

PixelClever’s picture

I don't know what is going on with the drupal cvs system. This is getting ridiculous. The change is a simple one, on line 43 change drupal_goto($languagepath); to drupal_goto($languagepath['path']);

I will try committing it again, but it seems like there is something wrong.

PixelClever’s picture

I just checked in the actual cvs repository the file is correct http://drupalcode.org/viewvc/drupal/contributions/modules/languageinterf...

but for some reason the packing script isn't getting the right version.

PixelClever’s picture

I just checked 3.5 and it has the change I made. Hopefully that takes care of it.

dmjossel’s picture

Looks OK from here.

UPDATE: Or, rather it did. Now, in situations with absolute URLs where the module was appending /Array, now I'm getting a doubling of the language prefix.

If I enter:

http://sitename.com/en/node/123

I'm getting:

http://sitename.com/en/en/node/123

It doesn't happen on relative URLs.

Egmund’s picture

Thanks for your efforts Aaron, but I am sticking with the 6.25 version untill I get an 'all clear'. Seems there is still problems (& still wondering what was wrong w. 6.25).

PixelClever’s picture

Status: Active » Closed (fixed)
PixelClever’s picture

To everyone If you have a specific problem in the 3.6 version open a new issue. This issue started badly (very poor initial description) and is very mixed up. Please only reopen this issue if for some reason the actual code is identical to the previous version (This has happened several times due to cvs errors).

@denko - Please only post comments if you are testing the new version and have results to confirm. Every comment is sent to my inbox, and unproductive comments detract from actual information from testers. If you want to know why the module was updated, then read the issue queue or compare the source code. The code will not go back to 2.5. You are welcome to use whichever version you prefer.