Active
Project:
Comment edited
Version:
6.x-1.4
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
14 Jan 2011 at 08:44 UTC
Updated:
30 Mar 2013 at 12:16 UTC
Jump to comment: Most recent file
Comments
Comment #1
snufkin commentedIts planned, but I wont have time in the near future. It would help if people would chip in, or would contribute patches though.
Comment #2
NPC commentedSubscribing, I like the idea of the module, so would like to use it on my future D7 sites.
Comment #3
playfulwolf commentedyep, like the idea also.
did not press Follow with hope to get reaction from dev's
Comment #4
snufkin commentedthe developer reacted in #1, unless someone helps me, I don't think i'll have time for an update in the foreseeable future.
Comment #5
Oleksa-1 commentedUntil 7 version will be released I offer temporary decision
Comment #6
robmalon commentedThanks for getting the ball rolling on this Oleksa. I was poking around the code as I might add some of my own modifications. Anyways, I was trying to understand your logic of why you have "changed" and timestamp" db columns. Both have a description of "The timestamp of the last change on the comment". And the only difference in insertion is "changed" being 1 second later than what is being put in the "timestamp" column.
Comment #7
snufkin commentedThanks for the help, I'm happy to commit it to the repository as soon I can review the code. Could you please roll a patch against 6.x-1.x-dev?
Comment #8
Oleksa-1 commented@robmalon@snufkin really you can use only "timestamp" instead of "changed" and timestamp" in this case you will need to do LEFT JOIN 'comments' to compare data in function ok_comment_edited_comment_view . I use "+1" to exlude LEFT JOIN i understand that it is not correct way.
Also you can use user_load to get 'authname' insted to keep it in table. But I wanted to make module very quick thats why I used that 'stranged' logic;) and this code is not good for making patch. But it is easy to make correct logic in it.