Following from #1023414: Add tabs to admin scheduler settings page I had intended to add the Lightweight Cron help text using hook_help() but instead you have added it directly into the form. I think it is preferable to separate the wordy text from the operation of the form, so here is a patch which makes this change. The benefit of having a hook_help is that you automatically get a 'more help' link which includes a link to the permissions. Additional help can be added in future, but it is good to have the function, as this is a basic drupal hook which all modules should have.

Comments

jonathan1055’s picture

Status: Active » Needs review
StatusFileSize
new3.16 KB

Here's the patch, against the latest dev of 14th Jan.

eric-alexander schaefer’s picture

Status: Needs review » Fixed

Oh, I didn't know that. Thanks a lot.
http://drupal.org/cvs?commit=483594

jonathan1055’s picture

Version: 6.x-1.8 » 7.x-1.x-dev
Status: Fixed » Patch (to be ported)

Requires a D7 version.

jonathan1055’s picture

Status: Patch (to be ported) » Needs review
StatusFileSize
new2.35 KB
new347.98 KB
new213.04 KB
new370.57 KB

Here is the patch for D7. In the main settings page I have expanded the help to include a link to the content type admin page. Also for the main help section I have added a link to the readme.txt file - the attached screen grabs show these, and I have hovered over the link to show where it is poiting to.

eric-alexander schaefer’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.