I have taken some ideas from the modalframe_register and create a modalframe_login of my own. I kind of needed a few customizations and also get to know the modalframe API quite extensively for other uses and this served my purposes. I find it best to do something different that what you were doing because I needed it a bit more simplicity and that would fit in nicely if JS was disabled

I recently stumbled upon #871990: "Forgot Password" appears in modalframe login latest comment about your major changes, some of them might have been addressed by me as well in this alternative module.

I am attaching this for review. I am tempted to upload this module as a separate project in which I would ask your help to contribute/give support to this module if you want to, and if you think it's a good idea, to remove it from modalframe_contrib. But before doing any of that, I wanted to ask you about your thoughts and/if you just prefer to keep your modalframe_register module as it is and where it is, in which case that's just fine and my module alternative can stay here for future references or uses, or even for an idea or two, if someone else needs it.

I called this module modalframe_login not to conflict with yours.

This module tries to work in a drupal site as close as possible with how the login/register and password retrieval works without any modal. It doesn't need you to set up either new blocks or to add new links to the menu system.

The JS side of the module dynamically changes the user/login, user/pass and user/register links to the modal/* alternatives.
It supports the modalframe-exclude class so certain links can be opened within the modal windows.

It keeps things very simple that can be easily extendable via theme templates and/or form alterers.

It also imlement the JS drupal theming method so themers can override modal behavior on their themes without hacking this module.

CommentFileSizeAuthor
modalframe_login.zip2.42 KBhanoii

Comments

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
Status: Active » Needs review
yaoweizhen’s picture

yaoweizhen commented

The "request new password" replace login window is better than two forms in one windows. Worked well. :)

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented

I've done a few other further improvements to this module, shall I contribute this?

pcarman’s picture

pcarman commented

Can you post the improvements you made to your module?

While I think this would be a great addition to this module set, it looks like this module has not been updated in a few months. Is this still being maintained?

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented

I think I might create a new project out of this soon.

yaoweizhen’s picture

yaoweizhen commented 
'a[href="/user/login"]:not(.modalframe-login-processed):not(.modalframe-exclude)'

Use base path variable as prefix of path.

'a[href="' + Drupal.settings.basePath + 'user/login"]:not(.modalframe-login-processed):not(.modalframe-exclude)'

If you logged in, the page hasn't been refreshed. What's values in "args"? I tested the "args" is empty.

Drupal.modalframeLogin.onSubmitCallback = function (args, statusMessages) {
  if (args.redirect) {
    if (args.redirect == '.') {
      location.reload();
    }
    else {
      location.replace(args.redirect);
      // Redirect to specified destination.
      //setTimeout(function() {window.location = args.redirect;}, 1);
    }
  }
};
itserich’s picture

itserich commented

I installed modal login and included the user/login link in a node, but it links to the regular login page, no popup.

Does the input filter need to be configured, or something else?

itserich’s picture

itserich commented

Modalframe_login works fine as a link from the Primary menu but not as a link from within a node, so am guessing it may be an input filter configuration?

My filter has a "Lightbox modal filter" but that does not fix it.