Needs review
Project:
FFmpeg Wrapper
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
15 Jan 2011 at 08:55 UTC
Updated:
15 Jan 2011 at 22:35 UTC
I noticed my ffmpeg convertion in my media mover wasnt setting bitrate even though it was passed fine...
Around line 615 of ffmpeg_wrapper.module:
if ($params['ffmpeg_video_br'] && ! $params['ffmpeg_video_br'] == 'source') {
didn't enter the if statement when i passed the video bitrate param, but this worked:
if ($params['ffmpeg_video_br'] && $params['ffmpeg_video_br'] != 'source') { // or !($params['ffmpeg_video_br'] == 'source')
Thanks,
-Arian
Comments
Comment #1
arthurf commentedThanks for the catch. I committed the fix, please go ahead and test.