labjs seems to break boost stats block "popular content", the block is visible when authenticated (no-cache) but displays blank when browsing as anonymous user. You can see this in action at - http://www.megaleecher.net/

Comments

jcisio’s picture

jcisio commented

I look at your page, there is a jQuery(document).trigger('fb:init'); that generates an error. It needs to be fixed first!

This JS block is not in a LABjs wrapper, then jQuery is not available at the execution time. You may want to do it manually. I wanted to parse all JS block in the page.tpl.php, not only $script. But I thought it could lead to more compatibility problem.

Maybe an option in the settings page? Any thought?

deepesh’s picture

deepesh commented

That seems to be a code from Facebook Connect module, are you sure the issue is with that code because as far as I can recall this was working fine before Labjs.

jcisio’s picture

jcisio commented

I didn't say that the problem is caused by that module. It's just because it is incompatible with LABjs, and it needs fixed. Try to debug and find the error, then try to fix it. After we know how to fix it, we'll decide where to put that fix, in LABjs or in fbconnect.

But, debug and find the error first.

deepesh’s picture

deepesh commented

Hi,

I disabled the module "fbconnect" and cleared the boost cache but the issue is still there ! can you pls. check again.

Thanks

jcisio’s picture

jcisio commented

Did you use Firebug to debug it? Currently there are 2 errors:
$.getJSON(Drupal.settings.basePath...
var boost_xhr = $.ajax({url: Drupal.settings.basePath...
Put those JS block in $LAB.queue(function() {...}); (hack the boost module to do that). If it works, then we know where is the error, I can ask boost.module maintainer to fix it, or LABjs will have special treatment for it. If it doesn't, then continue to look for another error.

However, I'll release a new version with a greedier method.

deepesh’s picture

deepesh commented

I am not a web-dev so would not mess with this javascript/php stuff, I would suggest you ask "boost" dev to look into this matter.

jcisio’s picture

jcisio commented
Title: Boost stats broken with labjs » Allow LABjs to rewrite JavaScript in other regions (content, closure...)
Category: bug » feature

I've committed a new feature. See README.txt for more info.
http://drupal.org/cvs?commit=482684

deepesh’s picture

deepesh commented

Updated labjs and boost module to latest dev release, cleared boost cache and the problem still exists.

jcisio’s picture

jcisio commented

Did you read README.txt?

jcisio’s picture

jcisio commented
Status: Active » Fixed

Code was committed in #7

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.