Download & Extend
Maxlength » Issues

Do not count html markup

Posted by haggins on January 15, 2011 at 1:45pm
Project:Maxlength
Version:6.x-2.0-beta2
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:needs work
Issue tags:ckeditor, maxlength, needs backport to D6, tinymce, wysiwyg

Issue Summary

Attached is a patch against 6.x-2.x-dev and a submodule. If the submodule is enabled your html markup won't be counted anymore. The submodule provides one plugin for each ckeditor and tinymce.
Tinymce untested.

This issue is forked from #314508: Doesn't work with WYSIWYG (tinyMCE and CKeditor)

AttachmentSize
314508.patch3.1 KB
wysiwyg_maxlength.tar_.gz1.82 KB
Login or register to post comments

Comments

#1

Posted by haggins on January 15, 2011 at 1:45pm
Status:active» needs review

#2

Posted by haggins on January 15, 2011 at 1:58pm

There are some problems I could not solve so far:

  • maxlength module checks if this submodule is enabled and if yes it strips the html. However, if you are using wysiwyg-module and don't activate the editors plugin for a specific input format, maxlength module will strip markup anyway
  • Sometimes the first character counts double. Maybe the regexp should be improved?
  • The counted length of visible characters doesn't always match 100% with the real length of the text. On a maxlength of 4000 I see a difference up to 5 => improve regexp
  • At tinymce the counter is updated by fired editor events. At ckeditor I used a 500ms interval which looks more stable for me. Please test on some weak machine for performance.

#3

Posted by smoothk on January 17, 2011 at 4:26pm

Hi there,

and thank you!
Your patch and module are working real good with TinyMCE right now, I'll be testing them more and more in the next days.

One question:

I'd like to add support for nodepicker and for imagebrowser modules - so I guess I should add something to the function strip_tags() of your module, in order to also strip any [nodepicker==*.] and [ibimage==*.] from the character count.
The two modules always put their output starting with these strings - but I wouldn't know how to add them to your function.

Could you please point me in the right direction?

#4

Posted by haggins on January 17, 2011 at 6:06pm

Hi smoothk,
nice to see it working fine with tinymce, too.
If you want to modify the regular expression of the strip function you need to edit two lines:
1. in line 248 of maxlength.module
2. line 62 of wysiwyg_maxlength/editor_plugin.js (or line 48 in ckeditor_plugin.js)

Maybe it would be more beautiful to call a hook so that everyone can implement it in his custom helper module. It should be possible in any way to deliver the additional regexp within Drupal.settings to the js.

But at the moment editing the lines directly is the only way...

#5

Posted by hefox on March 12, 2011 at 6:04am

Don't currently have the need for this, but looked at the patch anyway.

The patch appears to have one place where there was no reason for a change (a ) was moved to a a line above), so that should likely be removed.

Personally, I dislike parts of the patch. Having it check if a module exists than calling the function seems a bit unflexiable; it would be better for it to have a way for others to hook in.

A tiny issue, but I think it would be more correct to call it maxlength_allowhtml or at least have maxlength as the start as you're looking to bundle it with maxlength, right? (I personally think it would be better if the main module provides the support if the functionality is light enough. Modulitist is a horrid, horrid disease u.u!)

As for the module itself, check the coding standards handbook page/s and/or use the module coder to clean it up.

#6

Posted by acfas.jfcartier on April 1, 2011 at 5:04pm

Hi folks,
I have a question about this topic, but first I'll contextualize my situation.

I'm putting maxlenght on a textearea that is affected by TinyMCE. It works fine, but there is a problem at the submit. It takes the content of the wysiwyg and validates it WITH the HTML tags.

ie:
* My maxlength is 18
* here is what is shown in tinyMCE --> "This is a sentence" (18 chars there!)
* here is what's in the source --> "<p><strong>This</strong> is a sentence</p>" (42 chars including html tags chars)

When I submit the form, CCK validates the wysiwyg content and notices that 42 chars is higher than 18, so it prints an error!

My question is, is there a way fix that problem.
Tell me what you think

thanks

#7

Posted by galacticoverlords on October 11, 2011 at 11:02am

Any possiblity to get this working in drupal 7?

#8

Posted by Schnitzel on November 9, 2011 at 12:28pm
Version:6.x-2.x-dev» 7.x-3.0-beta1

yes! the new 7.x-3.0-beta1 Release has a new checkbox where you can select if HTML Tags should be stripped out (called "Truncate HTML").
If you enable this, HTML Tags are ignored during the JS Limit Calculation and also during the Drupal Core Calculation.

#9

Posted by Schnitzel on November 9, 2011 at 12:33pm
Status:needs review» closed (fixed)

closed, please create new issues if there is a problem

#10

Posted by firebus on November 12, 2011 at 1:22am
Version:7.x-3.0-beta1» 6.x-2.x-dev
Status:closed (fixed)» needs work
Issue tags:+needs backport to D6

reopening as this feature is still desired in D6.

haggins' original patch provides html tag stripping to wysiwyg integration, but it's broken for me, in 6.x-2.0-beta2 for non-wysiwyg fields.

#11

Posted by firebus on November 13, 2011 at 11:08pm
Version:6.x-2.x-dev» 6.x-2.0-beta2

here is a patch that updates the patch in OP to work with 6.x-2.0-beta2 and to work when wysiwyg is not enabled (either the editor is disabled by the user, or the module is not enabled at all)

the following changes have been made:

  • Don't check for the existence of wysiwyg_maxlength module, to address hefox's comment in #5
  • Don't try to truncate text when the text is over-limit. Maxlength truncates with substr() when the text is too long. This does not do the right thing when there are tags in the text that we want to ignore. It also makes it impossible to add a legal tag to the end of the string when there are no characters remaining. Instead we rely on maxlength's validation handler to deal with over-length strings.
  • A bug was fixed with the code in maxlength.module that tried to increase "remaining" but the number of stripped characters

before this is ripe, we should add a setting, so admins can enable and disable this feature. it would also be nice to find a good way to truncate. i haven't looked at the implementation in D7. if they have a good way to truncate we should steal it, otherwise we should punt.

AttachmentSize
1027966-strip_tags-11-D6.patch 5.41 KB

#12

Posted by firebus on November 14, 2011 at 6:06am

Sorry - above patch has a small but horribly fatal typo. Please try this instead

AttachmentSize
1027966-strip_tags-12-D6.patch 5.43 KB

#13

Posted by vistree on March 6, 2012 at 5:21pm

Hi, thanx for your work. But I don't understand on how to apply it. Is this a patch I have to apply on the patch in #1? Or do I first have to apply patch #1 to the beta-Version of maxlenght (which does not work) and afterwards your patch?

Kind regards

nobody click here