Trying to add the requisite search engine verification tags is extraordinarily complicated for something that should be incredibly simple and this is because Nodewords is really designed for tags that should appear on multiple pages, not just on the homepage. I really think we should just remove this functionality and promote a separate module.

Comments

dave reid’s picture

Maybe Site verifications should implement the Nodewords API?

damienmckenna’s picture

Sounds good.

So what do we need? I was thinking:

  1. Note in the Nodewords README.txt file & project page about the change.
  2. Add a note to the Site_Verify README.txt and project page about the change.
  3. Convert the settings, e.g.:
    • Specifically do NOT remove the settings, leave them as-is. Write an update & import script for Site_Verify that checks to see if the settings were configured for Nodewords and import them if found.
    • Write an update script for Nodewords to convert the settings for use with Site_Verify.
  4. Whaddya think?

damienmckenna’s picture

Given that Site_Verify has conversion scripts for other modules already, I'm going to write a patch for it to import the Nodewords settings.

damienmckenna’s picture

Site_Verify issue for the conversion script: #1028246: Import script for Nodewords settings

damienmckenna’s picture

I've written a patch that converts Nodewords settings, both as an update script and during installation.

damienmckenna’s picture

StatusFileSize
new15.24 KB

Here's a patch that removes the nodewords_verification_tags module and adds a small update script to both remove the now unnecessary variables but also notify users of the change.

damienmckenna’s picture

Status: Active » Needs review
damienmckenna’s picture

Issue tags: +v6.x-1.12 blocker

I think this should be in the next release.

damienmckenna’s picture

StatusFileSize
new15.41 KB

Small update to the patch that fixes variable_get() calls and removes the record from the {system} table.

Status: Needs review » Needs work

The last submitted patch, nodewords-n1028086-2.patch, failed testing.

damienmckenna’s picture

Status: Needs work » Needs review
StatusFileSize
new15.41 KB

Small SQL bug in the last patch.

Status: Needs review » Needs work

The last submitted patch, nodewords-n1028086-11.patch, failed testing.

damienmckenna’s picture

Status: Needs work » Needs review
StatusFileSize
new3.97 KB

Rerolled the patch.

damienmckenna’s picture

StatusFileSize
new11.36 KB

Rerolled for 6.x-1.x, lets see if it passes this time.

damienmckenna’s picture

Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)
Issue tags: -v6.x-1.12 blocker

Automatically closed -- issue fixed for 2 weeks with no activity.