As far as I can see, this module does not work in IE7. See the screenshot I added. The html-code in the source seems okay, but in IE7 I get a "broken image" display.

I tested this in FF1.x, FF2.0, IE6.x and IE7. They all work, except IE7. I wish I had a work-arround, but can't find the exact source of the problem.

CommentFileSizeAuthor
kruisje.jpg41.15 KBPibu

Comments

TheWhippinpost’s picture

From the screenshot, there's not much one can determine apart from you having IE7 set to not allow activeX

Pibu’s picture

Thanks for your comment. I thought you may be right, but then again, why does the same youtube-embedded movie work in the same IE7 browser when I set the input format to "full html"?

In other words: it doesn't work in IE7 when I use an input format with the embed-filter, but it DOES work when I set it to full HTML.

alliax’s picture

I confirm this, the problem is in the html code, it's fucked up in all browsers but ie7 seems picky about this and doesn't display the video.
why it works with full html? Because the embed filter is only applied to limited html, not to the full html.

Look at this exemple:
http://video-downloads.12freemusic.com/harmonica_le-plat-pays-jacques-br...

<object width="425" height="350"/><br />
<param name="movie" value="http://www.youtube.com/v/pPqJXt1fhXc"></param><embed src="http://www.youtube.com/v/pPqJXt1fhXc" type="application/x-shockwave-flash" width="425" height="350"//></embed></object>

As you can see the embed tag finishes with a double //> which is nothing like what I entered and is fucked up by the embed filter, I tried to look at the source but I don't understand the regex thing, and at the time IE7 was very new, now maybe I should really get serious about this as most people come with IE, maybe not a majority with IE7 but the time will come.

Emiliano’s picture

Hi,
this is the fix that worked for me: around line 269, find:

      // 3 part arrays are single, closed tags: <embed.... />
      else if (count($input) == 3) {
        $output .= '/>';
      }

Change:

        $output .= '/>';

For:

        $output .= '>';

That's it. :-)

Cheers,
Emiliano.

alliax’s picture

Thank you emiliano, I confirm your changes works now for IE7 !

What one has to do is to change the line, upload the module and then go through all his content and edit it, change a little thing (like add a . somewhere) and save the changes, so that the new filter is activated on each content.

You have to do it for all content pages, unfortunately it's not live filter.

Pibu’s picture

Status: Active » Fixed

Thanks for the fix! It works in IE7 now. :)

Anonymous’s picture

Status: Fixed » Closed (fixed)