Blatant title :) No idea on the exact steps, but it's going to change.

And in order to not break the existing, and as always and in general, we start with tests. :)

CommentFileSizeAuthor
skinr-HEAD.configure.0.patch5.6 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Needs review
jacine’s picture

jacine
she/her
Location New York
commented
Status: Needs review » Active

HAWT! 77 passes, 0 fails, 0 exceptions, and 21 debug messages

Yay! Committed: http://drupal.org/cvs?commit=483076

jacine’s picture

jacine
she/her
Location New York
commented

This issue doesn't explain anything about what needs to happen, so no one other than you has any idea what should be done here, btw.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Note that I don't have a "master plan" either, I only know about the factual and actual problems of the current module design. And those, we need to fix.

Based on our last call, this is about some fundamental changes we need to discuss; e.g.:

  1. Remove skin configuration integration stuff from third-party forms; i.e., only keep Skinr's own edit form to configure a skin.
  2. Store the exact and effective configuration of a skin for a particular theme, so we're able to retrieve all skins to apply in a performant way. Therefore, a skin configuration object only applies to one theme, one theme hook, and one skin.

    We also discussed that skin configurations can be applied to multiple themes currently. Ideally, we leave that to a separate issue, and keep the idea in mind that "cloning" an existing skin configuration for another theme would be the simplest solution.

  3. And of course, further decouple the current mess of having to load skin info when we only need and want to apply skins and skin info is totally not required.
sun’s picture

sun
Primary language German
Location Karlsruhe
commented

#1044222: Remove skin configuration functionality from third-party forms

moonray’s picture

moonray commented

#1082842: Update storage of skin configurations to give more granular control should take care of the first part of 2. Store the exact and effective configuration of a skin for a particular theme, so we're able to retrieve all skins to apply in a performant way. Therefore, a skin configuration object only applies to one theme, one theme hook, and one skin.

moonray’s picture

moonray commented

And for 3. #1147936: Decouple having to load skin info when we only need to apply skins.

moonray’s picture

moonray commented

For the second part of 2. see #1163676: Allow cloning of exisitng skin configuration to apply to another theme.

moonray’s picture

moonray commented
Title: Change skin configuration » [META ISSUE] Change skin configuration
moonray’s picture

moonray commented

Closing this issue. The last issue in #8 needs discussing and might not even make it in if not needed.

moonray’s picture

moonray commented
Status: Active » Closed (fixed)