Allow audio player plugins

I really like the idea of using another flash audio player. Is there any chance you will be doing this for the 4.7 Drupal version too?

Re-uploading updated jeroenwijering player inc files since it is under a creative commons license. Drop these files into your audio/players folder.

hey zirafa, this is in response to this post

http://drupal.org/node/139581#comment-237188

which redirected me post 24 here.

are you sure your jeroen inc file is correct?

you don't seem to have provided a callback for 'theme_xspf'.. it looks like you can get around that by calling theme_audio_jeroenwijering_player directly and passing $path.. but just thought i'd let you know for consistency sake and possibly providing a separate $output for a full size player with playlist at least semi visible.

i'll give your code a try and see if that works versus what i was having problems with in my post referred to above.

thanks

I don't understand your question - you configure which players you use in the audio players configuration page, but you can call the theme function directly, which is the way it should work.

zirafa, i think you need to look at my original post. my problems are pretty well documented there (i think). i moved the followup post here per your request in the original post but i think that may have thrown you off.

fwiw, i just tried your jj code patch and the jeroen players still do everything correctly except for play the actual mp3's. like i stated in the previous post, they are able to pull the xspf feed so that a playlist is populated correctly with the mp3 filenames in the player. When i rollover them, the color / state changes but when i click on one of the files in the playlist nothing happens (e.g. the mp3 doesnt' appear to get loaded so nothing ever plays).

if i pull up the xspf file that represents the playlist being loaded it looks like this (first portion of it):

−

Album 1
joe
joe
http://airik51.com/media/music/album1
http://airik51.com/node/63/xspf

−
	
−

http://airik51.com/audio/play/61
Anne Hytta
master
fyrispel
Anne Hytta - fyrispel
1:07
http://airik51.com/
http://airik51.com/anne-hytta-fyrispel

NOTE: the links above are on a localhost so you won't be able to access them

So if i cut n paste the location of the song, http://airik51.com/audio/play/61, in the browser bar, i'm prompted to play the file in winamp and it works. so the paths appear to be correct. the file is a valid mp3 file with the correct sample rate.

I'm missing something silly. What is it?

As i said in the original post, using my original code (not yours but i imagine the results would be the same), if i dropped down to jeroen version 2.3 player, everything works.. what's different about the players that's causing the problem?

thanks, sorry if the cross posting is causing confusion

I did read the original post. I redirected you here because there was already some code for the joeren player. My guess is the flash player doesn't like URLS without .mp3 because it doesn't know how to handle the file.

Allright, i think you're on to something here... if you look in your jeroen .inc file this exists at the top:

'theme_node' => 'audio_jeroenwijering_node_player',
'theme_xspf' => 'audio_jeroenwijering_xspf_player',

But only the 'node_player' is actually defined.. not that big a deal..

if you look at the 'node_player' function, it is designed to trick the jeroen player into thinking the files are mp3's (e.g. have extensions appended to the menu path) per:

function theme_audio_jeroenwijering_node_player($node, $options = array()) {
// make sure it's compatible with the flash player
if (!audio_is_flash_playable($node)) {
return NULL;
}

$options['file'] = check_url($node->url_play).'/file.mp3'; //spoof an mp3 extension since play urls have none

return audio_jeroenwijering_player($options);
}

But when / where / how does this function get called?

what i don't understand is that if you walk through the code, it's going to eventually theme a single file player which isn't want i want. however, i DO want that first half code that tricks the path.. BUT i want it to be called when the jeroen flash player tries to load the original path supplied by the xspf feed..

Where would that code need to be patched to make it alter jereoen paths of type audio/play/nid on jeoroen flash player calls only?

does that make sense.. i think it does to me now, i just don't know where / how to fix it.

ok, that gets called when you load menu path audio/play/nid..

it sets the player for a single audio node and alters the file path to trick the jeroen single player into thinking it's playing an mp3 file as your original suggestion implied.

that works!

so i think this is our problem.

i'm not sure if the playlist location itself needs to be modified (given a faux mp3 ending) or if when you click on a flash player file in the playlist, the standard menu path representd by playlist location needs to be intercepted for and altered by some where in one of the audio modules to have the faux mp3 ending (but only when the player is a jeroen with an xspf feed).

make sense?

I don't know the audio modules enough to no where to make this change and which one is the ultimate and best solution.

thanks for following this through.

I confirmed this is the problem.. whew hooh!

I temporarly fixed it with a hack but i'm wanting your input to do this a better way:

what i did:

1) went into: audio/contrib/audio_feeds
2) changed 1 line in function: audio_feeds_generate_xspf
3) appended "/file.mp3" to to the value in the location element

OK she works now..

But this is a global change that will affect every xspf playlist not just for jeroen player. That may cause another player to break.. probably not but it's probably cleaner to only add this on jeoren players.

So is there a way to determine *which* player type (slim, xspf, jeroen) is creating the playlist.. either checking a variable or calling a hook?

If we can do that, then we can do a simple check and only change location element for only jeroen types of feeds!

let me know.

Fixed issue being reopened for support spam. Closing.