The system settings page allows the GD toolkit to be selected even if it is not installed. The error is detected when the form is next loaded, rather than when it is submitted. The form error prevents any valid settings from being submitted.

The attached patch causes validation to be performed before the form is submitted rather than after. It patches both system.module and image.inc.

CommentFileSizeAuthor
gd-toolkit.patch2.83 KBDarren Oh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Darren Oh’s picture

Darren Oh
Primary language English
Location Lakeland, Florida
CreditAttribution: Darren Oh commented

An equivalent patch for Drupal 5 is available in issue 102987, so this fix will not need to be ported.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented

@Darren Oh - I'm curious about how to test this. Basically we need to have an installation with gd disabled and imagemagick enabled. Is that right?

killes@www.drop.org’s picture

killes@www.drop.org CreditAttribution: killes@www.drop.org commented

I have an install without GD and no image toolkit is offered.

killes@www.drop.org’s picture

killes@www.drop.org CreditAttribution: killes@www.drop.org commented

Strange: Once I copy image.imagick.inc to the includes directory, I get both GD and imagick offered. If I remove it again then there is no choice offered.

killes@www.drop.org’s picture

killes@www.drop.org CreditAttribution: killes@www.drop.org commented

ok, I understand now why I don't get a selection offered with only one toolset present. However I already get a validation error without this patch.

killes@www.drop.org’s picture

killes@www.drop.org CreditAttribution: killes@www.drop.org commented
Status: Needs review » Fixed

ok, some testing revealed that this indeed makes the form much better behaved.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)