I installed and configured ImagePicker. It seems to work fine, but it's giving me the error message "Strict warning: Only variables should be passed by reference in imagepicker_quota_ok() (line 2898 of /opt/local/apache2/htdocs/sites/all/modules/imagepicker/imagepicker.module)." I have tried enabling and disabling quotas. That doesn't affect it.

Again, it works fine.

CommentFileSizeAuthor
#3 fix_reference_warning-1029792-0.patch648 byteschi

Comments

hutch’s picture

hutch commented

"Strict Warnings" or "E_STRICT" (in php.ini) in php 5.3.x are not always compatible with Drupal as far as I can tell. I have built all the forms in imagepicker in accordance with the examples provided in the 'examples' module and as shown in api.drupal.org and they all work fine.
My php.ini using ubuntu 10.10 (development box) suggests that "E_STRICT" is not for production use and as it has given me somewhat incomprehensible warnings (like this one) I have switched it off.
Messages can be set to log only in admin/config/development/logging in D7.
As far as "Coding standards" go I use the Coder module and get everything passed there before I release, that seems to be what I'm supposed to do.

hutch’s picture

hutch commented
Status: Active » Closed (works as designed)
chi’s picture

chi commented
Status: Closed (works as designed) » Needs review
StatusFileSize
new fix_reference_warning-1029792-0.patch648 bytes

Drupal 7 fully compatible with PHP 5.3. This error message is common issue for many modules and it should be fixed.

Here is patch for my case only. It seems like there is much work that still needs to be done to make the module fully compatible with PHP 5.3.

hutch’s picture

hutch commented

It looks like you have identified the cause of these messages, render() wants to see a variable (literally), so I have fixed this throughout, moving some instances to theming in the process.
Commited to dev.