Closed (fixed)
Project:
Menu Firstchild
Version:
7.x-1.1
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
17 Jan 2011 at 19:31 UTC
Updated:
8 Nov 2011 at 18:16 UTC
Jump to comment: Most recent file
Comments
Comment #1
anrikun commentedThis should not happen as in menu.inc, module index is set before drupal_alter is called :-(
Could you please try to clear your menu cache and see if notice goes away?
Comment #2
jon betts commentedIssue is still occurring after going to Performance and clicking on the Clear All Caches button.
Comment #3
anrikun commentedTry to disable Menu Firstchild then create a link.
Does the notice show up?
Comment #4
jon betts commentedDisabled Menu Firstchild, cleared caches and then created a link and did not receive the message.
Comment #5
anrikun commentedCould you please post or send me a dump of your tables:
menu_custom
menu_links
Comment #6
jon betts commentedSure. I've attached a zip of a sql dump of both.
Comment #7
anrikun commentedSorry, but I have just realized something:
Your issue is about Menu Firstchild used with the Shortcut module, right?
So that it is fully clear for me, list each step to reproduce the issue.
Also tell me what Core modules you have enabled and what your theme is.
Comment #8
jon betts commentedSure. I'm just testing out D7 to see if I may be able to use it for upcoming projects so at this point I'm just using the defaults, Bartik/Seven as my themes.
To reproduce, just go to any admin page where you can add a link to the shortcuts bar and click on the plus button that appears to the right of the title. The same thing happens in the Edit Shortcuts screen. As far as I know, these are the only ways to add shortcuts through the interface. e.g. admin/modules, add modules to shortcuts.
I went through and deactivated (but did not uninstall) all contrib modules and have the following core modules active:
Block
Contextual links
Dashboard
Database logging
Field
Field SQL storage
Field UI
Filter
Help
List
Locale
Menu
Node
Number
Options
Overlay
Path
Profile
Search
Shortcut
System
Taxonomy
Text
Toolbar
Update manager
User
Hope this helps!
Comment #9
anrikun commentedAll right, I was able to reproduce the bug and I have fixed it.
Can you get the last menu_firstchild.module from CVS and review it?
Comment #10
anrikun commentedComment #11
jon betts commentedUnfortunately I haven't had any luck getting CVS set up on my Mac. I've got CVS set up but haven't found clear (for me) instructions on how to set up specifically for Drupal. I think there is a way to make a patch though on Drupal.org, I'll look into it.
Comment #12
jon betts commentedI took a look at the changes that were made in CVS and they were easy enough for me to make so I did. I tested it out with the stripped down installation above and then I re-enabled a few dozen modules and the message has gone away. Thanks!!
Comment #13
anrikun commentedGreat!
Thanks a lot for reporting this bug and helping me to find it.
Let's mark this as fixed.
Comment #15
ludo.rThis issue is still there using version 7.x-1.0
I have this error message when adding a shortcut.
I cleared the cache.
I activated Shortcuts module after Menu firstchild, could this be the problem?
Comment #16
anrikun commentedThis has been fixed in dev, not in 7.x-1.0
so you need to get it from GIT.I will do a new release.Or wait a little,
Comment #17
anrikun commentedThere you are :-)
http://drupal.org/node/1335246
Comment #18
ludo.rOh!
Thanks for this new release! :-)
Comment #19
ludo.rDrupal isn't able to find the new version :
It seems several modules have the same problem. I just ran a cron before checking available updates.
Comment #20
anrikun commentedMaybe it takes some time before it get listed.
Grab it from http://drupal.org/node/1335246 directly.