Comments

WorldFallz’s picture

yep-- there will definitely be a d7 version I just haven't had a chance to get to it yet.

kreza’s picture

I'm also eagerly awaiting a version that works with D7 :)

elgandoz’s picture

sub..nice module!

drupa11y’s picture

Subscribing - Great to know ;-)

dwalker51’s picture

subscribe

peregrine’s picture

Any timeline for D7?

webankit’s picture

StatusFileSize
new113.05 KB
new1.68 KB
new0 bytes

My first patch... plz test {applied on head using git}

Jerome F’s picture

Status: Active » Needs review

Subscribing - changed status to match #7

(tired of subscribing ? http://drupal.org/node/34496 - http://3281d.com/2009/03/27/death-to-subscribe-comments)

plugandpray’s picture

i tried #7 jp_maphilight but it didnt work. I tested with the example on the README.txt.
In the settings page, the "JQUERY MAP HILIGHT PLUGIN STATUS" seems to be ok, "The Map Hilight jQuery plugin is available at: /sites/all/modules/jquery_plugin/jquery.maphilight.min.js"
Any help?

tks

13rac1’s picture

StatusFileSize
new18.07 KB

Attached is a patch against the current HEAD upgrading it to Drupal 7.x.

New features:

  • Drush support for plugin download: drush maphilight-plugin
  • No inline JS, now created as an external file. Supports JS aggregating
  • New maphilight features added to config: neverOn, groupBy, and wrapClass
  • Config option to not automatically add library to all pages
  • Uses Drupal Behaviors, fixes: #1053786: Map Hilight & Ajax not working together
  • Libraries API required
  • jQuery Plugin module no longer required, but still supported

Run git apply 1030332-D7Upgrade-10-D7.patch in the module root to apply.

13rac1’s picture

Version: 6.x-1.0 » 6.x-1.x-dev
Component: Miscellaneous » Code
StatusFileSize
new22.14 KB

Argh. Patch updated (git diff HEAD, not simply git diff) to include drush/jq_maphilight.drush.inc

WorldFallz’s picture

eosrei-- you rock! I'm still buried by my day job atm, but I hope to get to this before the weekend. I'll try to get a dev committed asap. Thanks so much for the patch.

13rac1’s picture

StatusFileSize
new22.14 KB

Updated again ;) Docs for groupBy and wrapClass are wrong at: http://davidlynch.org/js/maphilight/docs/ Both are bool, not string. Corrected.

WorldFallz’s picture

did a quick patch review-- looks great.

One thing though, the registry was partly rolled back and I'm not sure the files[] directive needs to be included in the .info file in this case.

13rac1’s picture

I was basing some changes on other modules. I agree, the file[] statement is unneeded.

WorldFallz’s picture

Status: Needs review » Fixed

ok-- patch committed (without the files[] directives in .info, and some coder style fixes).

Report any new problems in new issues against the 7.x-1.x branch. The dev release should be available within 12 hours.

Thanks again eosrei!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

WorldFallz’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Closed (fixed) » Active

@eosrei

can you comment on #1308734: Use of jQuery Map Hilight module broken if Drupal files directory is not in www root. (be sure to see the linked issue as well). Since the getcwd() wasn't in my d6 code, I have no idea if you had a specific reason for including it there. The d6 version works fine without it as far as I can tell.

13rac1’s picture

Status: Active » Closed (fixed)

See other issue.