Closed (fixed)
Project:
jQuery Map Hilight
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
17 Jan 2011 at 21:07 UTC
Updated:
15 Oct 2011 at 00:07 UTC
Jump to comment: Most recent file
Comments
Comment #1
WorldFallz commentedyep-- there will definitely be a d7 version I just haven't had a chance to get to it yet.
Comment #2
kreza commentedI'm also eagerly awaiting a version that works with D7 :)
Comment #3
elgandoz commentedsub..nice module!
Comment #4
drupa11y commentedSubscribing - Great to know ;-)
Comment #5
dwalker51 commentedsubscribe
Comment #6
peregrine commentedAny timeline for D7?
Comment #7
webankit commentedMy first patch... plz test {applied on head using git}
Comment #8
Jerome F commentedSubscribing - changed status to match #7
(tired of subscribing ? http://drupal.org/node/34496 - http://3281d.com/2009/03/27/death-to-subscribe-comments)
Comment #9
plugandpray commentedi tried #7 jp_maphilight but it didnt work. I tested with the example on the README.txt.
In the settings page, the "JQUERY MAP HILIGHT PLUGIN STATUS" seems to be ok, "The Map Hilight jQuery plugin is available at: /sites/all/modules/jquery_plugin/jquery.maphilight.min.js"
Any help?
tks
Comment #10
13rac1 commentedAttached is a patch against the current HEAD upgrading it to Drupal 7.x.
New features:
Run git apply 1030332-D7Upgrade-10-D7.patch in the module root to apply.
Comment #11
13rac1 commentedArgh. Patch updated (git diff HEAD, not simply git diff) to include drush/jq_maphilight.drush.inc
Comment #12
WorldFallz commentedeosrei-- you rock! I'm still buried by my day job atm, but I hope to get to this before the weekend. I'll try to get a dev committed asap. Thanks so much for the patch.
Comment #13
13rac1 commentedUpdated again ;) Docs for groupBy and wrapClass are wrong at: http://davidlynch.org/js/maphilight/docs/ Both are bool, not string. Corrected.
Comment #14
WorldFallz commenteddid a quick patch review-- looks great.
One thing though, the registry was partly rolled back and I'm not sure the files[] directive needs to be included in the .info file in this case.
Comment #15
13rac1 commentedI was basing some changes on other modules. I agree, the file[] statement is unneeded.
Comment #16
WorldFallz commentedok-- patch committed (without the files[] directives in .info, and some coder style fixes).
Report any new problems in new issues against the 7.x-1.x branch. The dev release should be available within 12 hours.
Thanks again eosrei!
Comment #18
WorldFallz commented@eosrei
can you comment on #1308734: Use of jQuery Map Hilight module broken if Drupal files directory is not in www root. (be sure to see the linked issue as well). Since the getcwd() wasn't in my d6 code, I have no idea if you had a specific reason for including it there. The d6 version works fine without it as far as I can tell.
Comment #19
13rac1 commentedSee other issue.