Resizing text proportionally and do it recursively for all the scope elements

Thanks a lot! This seems to work and solves the problem for me.

Great work!

Does this rewrite include code for the reset button? I'm not seeing anything for 'text_resize_reset'.

Please submit patches instead of module zip files. Here are the instructions on how to create patches: http://drupal.org/patch/create

k, tried to make a patch out of that.. there were some weird changes, like t() wrappers being removed around text.. I assumed that they were due to an older version of -dev being taken and removed them.. so take a look.

quite some issues with this:

1. on load, the font size of the elements selected in the config of the module are set to the maximum size..
2. the proportional increase is slightly buggy, say im increasing two elements, one of which starts at 15 and one at 10, and say the maximum is 18. Now when the first reaches 18, the second will still be at around 14 or something. However, you can still increase it to 18 by clicking on (note that now the first element just stays at 18) so eventually the proportions are lost..

thanks

erm, you should have also mentioned that your code doesn't work with spaces between the class/id/tag names.. so if in the config it says "field-a, field-b" it will look for ". field-b" and "# field-b" - fail :(

As for the weird on-load bug, is this code really necessary when a document is loaded??:

		if(font_size != 0)
		for(i=0;i<trs.length;i++) //initialize
		{
			text_resize_scope = trs[i];
			element_to_resize = getResizeScope(text_resize_scope);
			
			element_to_resize.each(function()
			{
				initTextElementSize(this,font_size,resize_step);
			});
		}

Hey, added a check that checks if all elements are resizable before actually doing it, it's called just before the resize loop around line 30:

			for(i=0;i<trs.length;i++)
			{
				text_resize_scope = trs[i];
				element_to_resize = getResizeScope(text_resize_scope);
				if (!resizableTextElement(element_to_resize,click_id,resize_step)) {
				  return false;
				}
			}

function resizableTextElement(elem,click_id,resize_step)
{
		//check if the children elements are resizable too
		var resizablechildren = true;
		$(elem).children().each(function()
		{
			if (!resizableTextElement(this,click_id,resize_step)) {
			  resizablechildren = false;
			  return;
			}					
		});
		if (!resizablechildren) {
		  return false;
		}
		// Set the current font size of the specified section as a variable
		var currentFontSize = parseFloat($(elem).css('font-size'), 10);
		// javascript lets us choose which link was clicked, by ID
		if (click_id == 'text_resize_increase') {
			var newFontSize = currentFontSize * resize_step;
			// Allow resizing as long as font size doesn't go above text_resize_maximum.
			if (newFontSize > text_resize_maximum)
			{
				return false;
			}
		}
		else if (click_id == 'text_resize_decrease') {
			var newFontSize = currentFontSize / resize_step;
			if (newFontSize < text_resize_minimum-0.001) {
				return false;
			}
		}
		return true;
}

The checks can be then removed from the resizeTextElement function..

I'll leave it to you to put this all together and look through it.. ;)

sub

Hey,

I'm not sure how to reproduce it.. sometimes it happens and sometimes not.. not having the code that I mentioned in #7 fixes the issue, and considering that there seems to be no point in that anyway..

As for the proportional resize, your reply does not say anything about the issue. Yes, the idea of this module/plugin is to increase text size. And yes, if it is not big enough it is not necessary to enlarge more. But what I was trying to point out is that it's possible that texts will be selected with different initial sizes, like the usual p tags, together with some headings or whatever.. And in that case, things need to stay proportional.

Cheers

OK, checked your site, and both issues appear on it:

1. If you go to the page, increase the font size, then reload the page, the sizes will increase automatically without any click. Are you storing this in some cookie or something? Anyway, it's very confusing and annoying.

2. On the home page, the news items in the middle start out with 12px for the text and 13px for the titles. And the maximum you have seems to be 16px. The first 2 times you click to increase the font size, both the title and the text increase simultaneously. However, if you click a 3rd time, the titles will not increase because they're already at the maximum limit, but the text still will increase once, actually becoming slightly bigger than the titles.. either way this breaks the proportions, as mentiong.

Hope this helps.

Cheers

I'm not a maintainer here, but all patches should be made against the latest -dev, and if you submit one, then set the status to "needs review" so that people can see that there is something to check here ;)

Unless this should be bumped to D7 or D8...