We need to sync the core translation code as released in Drupal 7.0, since there have been relevant changes. We'll need to backport this to the 7.x-1.x-dev branch.

CommentFileSizeAuthor
#6 translation-1031202-6.patch32.47 KBplach
#3 translation-1031202-3.DRUPAL-7--1.patch30.26 KBplach
#1 translation-DRUPAL-7--1.sync_.1.patch30.03 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Needs review
StatusFileSize
new translation-DRUPAL-7--1.sync_.1.patch30.03 KB

Holy smokes. Quite some.

Status: Needs review » Needs work

The last submitted patch, translation-DRUPAL-7--1.sync_.1.patch, failed testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Assigned: Unassigned » plach
Status: Needs work » Needs review
StatusFileSize
new translation-1031202-3.DRUPAL-7--1.patch30.26 KB

We were missing a couple of test files (patch against the 7.1 branch, working on the HEAD patch just now).

Tests pass on my machine, so this should be ready to go.

Status: Needs review » Needs work

The last submitted patch, translation-1031202-3.DRUPAL-7--1.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Reviewed & tested by the community

Let's go ahead with the 7-1 sync. Sorry, forgot to add the new files.

I really hope you already know which changes in there need to be forward-ported (or not)...? ;)

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Assigned: plach » Unassigned
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new translation-1031202-6.patch32.47 KB

Committed #3 to the 7-1 branch.

Here is the HEAD version: tests are supposed to run and pass.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented

Ok, bot green. This should be ready to go too.

Btw, I spotted a bug in translation_node_tab_access while trying to make tests pass: field translation permissions were applied also to node translations.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs review » Closed (won't fix)

Entity translation now works with core translation.