If you use latest version of jquery (1.4.3) in your theme instead of the default one, admin menu toggle does not work properly. (The admin panel does not show up anymore after the first time you hide it)

By using firebug I found out that a "display:none" property is added when the panel is closed. That property is not removed when trying to switch back to display the panel.

I reproduced the issue in FF and Chrome, I could not reproduce in safari.

I fixed it by adding .show() in the includes/admin.toolbar.js file, line 130:

   $('div.admin-blocks', toolbar).animate({width:'260px'}, 'fast').show();
CommentFileSizeAuthor
#2 admin_toolbar_js_display-1031568-2.patch663 bytesmdupont

Comments

salimai’s picture

Tested and working on 7.x-2.0-beta3 (change line 136 instead of 130). Thanks!

mdupont’s picture

Version: 6.x-2.0 » 6.x-2.x-dev
Status: Active » Needs review
StatusFileSize
new663 bytes

Confirmed, same issue here on latest dev version.

When first hiding the bar, Drupal.admin.toolbar runs $('div.admin-blocks', toolbar).animate({width:'0px'}, 'fast', function() { $(this).css('display', 'none'); });. Note that display property is set to 'none' at the end.

When clicking again on the button, the bar reopens by running $('div.admin-blocks', toolbar).animate({width:'260px'}, 'fast');. Note that the display property remains unchanged, so it doesn't display. It can be fixed with any method changing back the display property to 'block'.

Patch attached.

sickness29’s picture

Issue summary: View changes
Status: Needs review » Closed (outdated)

Development or support is not planned for D6. All D6-related issues are marked as outdated in a bunch.

Everyone can apply the patch above (not tested by the maintainers, tested by the community) to their D6 projects.
If the issue remains relevant for D10+ versions, merge requests with proposed solutions for a new module version (D10+) are welcome in a new follow-up issue.

Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.