Closed (fixed)
Project:
Drupal core
Version:
5.x-dev
Component:
upload.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
13 Dec 2006 at 23:37 UTC
Updated:
16 Jan 2007 at 10:30 UTC
Jump to comment: Most recent file
Comments
Comment #1
RobRoy commentedBah, my last message got deleted. Anyways, the patch needs some work. It adds back stuff that we removed in one issue above and some other stuff that's probably unneeded. I stripped down the headers to the bare bones and it looks like this makes PDFs behave EXACTLY the same in public/private files (open up in the current window).
I used web-sniffer.net to see what headers are sent for a public PDF and it looked like just Content-Length and Content-Type were the relevant headers and no name was used for Content-Type (which was causing errors with IE6 when the filename had spaces in it). None of the other stuff. So let's work up from this point to see if any other headers are truly needed for private files.
Please test this out on a variety of private files and maybe this is enough.
Comment #2
RobRoy commentedCorrecting version. Also, Dave there were some code-style/spacing issues in your patch FYI. Thanks for spearheading this issue, let me know how the latest patch works for you.
Comment #3
drummThe last follow-up with a patch mentioned it needs work.
Comment #4
RobRoy commentedActually, I was saying Dave's patch had some issues. The patch I posted in #1 is up for review.
Comment #5
dries commentedYes, this patch is needed to make things work. Committed.
Comment #6
(not verified) commented