When using Admin Menu in IE6 with its position set as fixed, the menu appears at the bottom of the page.
The patch below fixes that for the last remaining users of IE6.

CommentFileSizeAuthor
admin_menu-ie6-position-fixed.patch1.77 KBb-prod

Comments

Status: Needs review » Needs work

The last submitted patch, admin_menu-ie6-position-fixed.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented 
+++ admin_menu.js	18 Jan 2011 21:41:23 -0000
@@ -11,7 +11,16 @@
-      $('#admin-menu').css('position', 'fixed');
+      if (! $.browser.msie || parseInt(jQuery.browser.version) != 6) {
+        $('#admin-menu').css('position', 'fixed');
+      }

This fix would be sufficient IMHO.

Powered by Dreditor.

b-prod’s picture

b-prod commented

Do not forgot this part of the patch which is required to allow IE6 compatibility :

--- admin_menu.css	2 Nov 2008 21:36:22 -0000	1.25.2.4
+++ admin_menu.css	18 Jan 2011 21:41:38 -0000
@@ -94,6 +94,9 @@
+/* IE6 workaround for position: fixed */
+*html .admin-menu-ie6 { top: expression(((e=document.documentElement.scrollTop)?e:document.body.scrollTop)+'px'); }
+

Actually the format of my patches are always refused, because I use winCVS (windows format seems to not be compatible with the automatic validator).
I already had the same issue with other patches, and it was asked to me to use cygwin instead of winCVS. That's what I did, but the format was not good either and refused...

So I am going to install Linux soon, but if anybody can apply the patch (because it works, really) and create a patch file under Linux, I would be glad.

Otherwise, I will post a new patch when I will be under Linux, what is not for the next week unfortunately.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

I'm on Windows, too. Your patch was rejected by the testbot, because it contains Windows line-endings.

That's a configuration issue with your code editor/IDE, not your OS/platform. Check your editor configuration options and make sure that all newlines are Unix newlines (LF, not Windows CRLF). And while being there, also ensure that all files are saved in UTF-8 (without Unicode (BOM) signature).

If all fails, or regardless of the configuration options, you might want to try the global -lf option to cvs:

cvs.exe -lf -q -z9 diff -upN > whatever.patch
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Closed (won't fix)

Actually, I've no intentions to support IE6 even further. Actually reminds me to drop the workarounds from the D7+8 branches...