Noticed a few oddities. Any error messages are always above the content and in 2 instances, the content points to the messages "below". Changed it to "above".

Stray <p class="error"> removed.

List item refers to some "notes below". Removed it since it seemed confusing.

CommentFileSizeAuthor
#3 remove_stray_p.patch1.08 KBdvessel
#1 Picture 1_17.png71.93 KBdvessel
clean_update_strings.patch2.97 KBdvessel

Comments

dvessel’s picture

dvessel commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new Picture 1_17.png71.93 KB

Hmm.. Maybe I misunderstood. Look at the screen shot. I guess it's talking about any errors from the queries?

dries’s picture

dries commented

Mmm, these should display below. I guess they could be above, or below then?

dvessel’s picture

dvessel commented
Title: Cleaned up text in update.php » remove stray p.error in update.php
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new remove_stray_p.patch1.08 KB

Not sure of an approach. The errors on top comes from theme('status_messages') inside theme_maintenance_page() (as seen in the screen shot). But the text is pointing to the queries which can display errors itself. I guess it should be left alone. Looking at that screen is still confusing.

For now, just a minor cleanup. :\

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)