As we look at the code, das-peter and I think this should be 'base path', not 'path'. True?

function hook_translation_info($types = NULL) {
     'translation' => array(
       'translation' => array(
         'class' => 'TranslationCustomEntityHandler',
-        'path' => 'custom_entity/%custom_entity',
+        'base path' => 'custom_entity/%custom_entity',
CommentFileSizeAuthor
translation.base_path_api.patch1.05 KBrfay

Comments

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Issue tags: +dcsprint5

tagging

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs review » Reviewed & tested by the community

Yesss!

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

btw, base path sounds a bit odd and ambiguous, as it literally can mean the base path of everything and nothing. Shouldn't it be entity path?

das-peter’s picture

das-peter commented

subscribe

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Fixed

mmm, base path, resp. $this->basePath is used all over the place (and this partially duplicates Entity API module, I think :-/... ), so let's simply fix the docs for now.

Thanks for reporting, reviewing, and testing! Committed to HEAD.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented

@sun:

mmm, base path, resp. $this->basePath is used all over the place (and this partially duplicates Entity API module, I think :-/...)

Yes, I'm seriously considering to drop the translation handler class in favor of an entity wrapper: since we still are in deep dev stage I think we can lightheartedly take this path if we want to.

Status: Fixed » Closed (fixed)
Issue tags: -dcsprint5

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +dcsprint5

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.