update.php is missing some of the CSS required to make it look right - collapsible fieldsets for one aren't fully collapsing...

Most likely due to: http://drupal.org/cvs?commit=48032

Marking critical as this blocks RC1.

CommentFileSizeAuthor
#3 maintenance_css.patch1.16 KBedmund.kwok
#2 patch_77.txt1.14 KBwebernet
#1 patch_76.txt1.09 KBwebernet

Comments

webernet’s picture

webernet commented
Status: Active » Needs review
StatusFileSize
new patch_76.txt1.09 KB

Patch adds system.css and defaults.css to all maintenance pages.

Not the cleanest solution, but this problem stems from http://drupal.org/node/93079 where the calls to drupal_add_css() etc were removed...

webernet’s picture

webernet commented
StatusFileSize
new patch_77.txt1.14 KB

Revised patch uses drupal_get_path().

edmund.kwok’s picture

edmund.kwok commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new maintenance_css.patch1.16 KB

Rerolled, minor coding style issues. Fieldset in update.php collapsible after patch; guess its the only way to fix this without invoking the css preprocessor. Marking this RTBC :)

ChrisKennedy’s picture

ChrisKennedy commented

Patch fixes the collapsing for me on FF2, IE6, and Opera 9. I'm not sure why this is critical though - without the patch the fieldset just can't be collapsed but otherwise works fine.

neclimdul’s picture

neclimdul
He/Him
commented

Fixed things for me. +1

Anonymous’s picture

Anonymous (not verified) commented

tested and works for me

Steven’s picture

Steven commented
Status: Reviewed & tested by the community » Fixed

Tested and verified. Committed to HEAD, thanks!

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)