migrate interface takes forever (litterally) to load

Same thing with Iceweasel 3.5.8 on Debian.
It doesn't load the site migrate form. But it loads the platform migrate form.

While debugging with Anarcat we found that adding the following keys improves performance a lot:

alter table hosting_package_instance add key hosting_package_id_key (package_id);
alter table hosting_package add key hosting_package_nid_key (nid);
alter table hosting_package_instance add key hosting_package_rid_key (rid)

After this, a query that was taking 8 seconds went to 0.01 sec. The actual migrate page in the Aegir frontend went from over 2 minutes to about 15 seconds.

The bottleneck was found using Xdebug, which lead to _hosting_package_temporary_table(), called from hosting_package_comparison().

Here is more information on why those keys are necessary:

mysql> explain SELECT nid, short_name, old_short_name, version_code, schema_version, version, status from hosting_package p left join hosting_package_instance  i on p.nid = i.package_id where rid= 4603 ;
+----+-------------+-------+------+---------------+------+---------+------+--------+--------------------------------+
| id | select_type | table | type | possible_keys | key  | key_len | ref  | rows   | Extra                          |
+----+-------------+-------+------+---------------+------+---------+------+--------+--------------------------------+
|  1 | SIMPLE      | p     | ALL  | NULL          | NULL | NULL    | NULL |   2070 |                                | 
|  1 | SIMPLE      | i     | ALL  | NULL          | NULL | NULL    | NULL | 182496 | Using where; Using join buffer | 
+----+-------------+-------+------+---------------+------+---------+------+--------+--------------------------------+

mysql> alter table hosting_package_instance add key hosting_package_id_key (package_id);
Query OK, 182508 rows affected (1.30 sec)
Records: 182508  Duplicates: 0  Warnings: 0

mysql> alter table hosting_package add key hosting_package_nid_key (nid);
Query OK, 2070 rows affected (0.41 sec)
Records: 2070  Duplicates: 0  Warnings: 0

mysql> explain SELECT nid, short_name, old_short_name, version_code, schema_version, version, status from hosting_package p left join hosting_package_instance  i on p.nid = i.package_id where rid= 4603 ;
+----+-------------+-------+------+-------------------------+-------------------------+---------+------------------------------+--------+-------------+
| id | select_type | table | type | possible_keys           | key                     | key_len | ref                          | rows   | Extra       |
+----+-------------+-------+------+-------------------------+-------------------------+---------+------------------------------+--------+-------------+
|  1 | SIMPLE      | i     | ALL  | hosting_package_id_key  | NULL                    | NULL    | NULL                         | 182508 | Using where | 
|  1 | SIMPLE      | p     | ref  | hosting_package_nid_key | hosting_package_nid_key | 4       | aegirkoumbitnet.i.package_id |      1 | Using where | 
+----+-------------+-------+------+-------------------------+-------------------------+---------+------------------------------+--------+-------------+
2 rows in set (0.00 sec)

mysql> alter table hosting_package_instance add key hosting_package_rid_key (rid);Query OK, 182508 rows affected (2.18 sec)
Records: 182508  Duplicates: 0  Warnings: 0

mysql> explain SELECT nid, short_name, old_short_name, version_code, schema_version, version, status from hosting_package p left join hosting_package_instance  i on p.nid = i.package_id where rid= 4603 ;
+----+-------------+-------+------+------------------------------------------------+-------------------------+---------+------------------------------+------+-------------+
| id | select_type | table | type | possible_keys                                  | key                     | key_len | ref                          | rows | Extra       |
+----+-------------+-------+------+------------------------------------------------+-------------------------+---------+------------------------------+------+-------------+
|  1 | SIMPLE      | i     | ref  | hosting_package_id_key,hosting_package_rid_key | hosting_package_rid_key | 4       | const                        |  490 | Using where | 
|  1 | SIMPLE      | p     | ref  | hosting_package_nid_key                        | hosting_package_nid_key | 4       | aegirkoumbitnet.i.package_id |    1 | Using where | 
+----+-------------+-------+------+------------------------------------------------+-------------------------+---------+------------------------------+------+-------------+
2 rows in set (0.00 sec)

matt / bgm

I've had this running for quite awhile and it made a huge difference.

ALTER TABLE {hosting_package_instance} ADD INDEX hosting_package_rid_idx (rid)

Definitely welcome changes. Have not tried the other two yet though. thanks.