Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.When I have purchased a file product and go to the download page, the link it gives me is:
http://example.com/~crosenthal/drupal5/%3Cem%3E/~crosenthal/drupal5/?q=s...
That should be:
http://example.com/~crosenthal/drupal5?q=store/myfiles/1/download&file=c...
The reason is because locale translation is being performed on the entire html fragment, and the theme is marking up the url.
The fix is to localize just the text "download", not the entire HTML fragment.
Patch is attached.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | download-link-fix-try2.patch | 2.54 KB | chip |
| download-link-fix.patch | 2.7 KB | chip |
Comments
Comment #1
neclimdulThe alternative is to use @file-download-uri to bypass the checkplain. However since we are only translating a single word this is worth considering. I'd probably create a new create_link function though to avoid confusion. We can keep the create_url function as it is still useful as a wrapper for url.
Comment #2
chip commentedDoes the attached work better for you?
Comment #3
chip commentedcan somebody review the patch attached to my previous comment?
Comment #4
brmassa commentedGuys,
its fixed already.
regards,
massa
Comment #5
(not verified) commented