Better AX shortname construction is needed, using only last URI path isn't working for some parameters e.g. http://axschema.org/contact/phone/home or http://axschema.org/contact/city/home (they both will get short name "home").

Additionally "http://axschema.org/" check prevents any AX extension to use the openid_ax_client hook, so I removed it in the patch.

I attached also screenshot of my example request, which was generated using this patch. I know, dvm() will be better, but I made it this way, so...

CommentFileSizeAuthor
#6 1033292-6-openid_client_ax-ax_extensions.patch3.53 KBxamanu
#5 ax_extensions_avoiding_namespace_collision-1033292-5.patch3.53 KBxamanu
#2 openid_client_ax_shortname.patch2.17 KBwojtha
#1 openid_client_ax_notices.patch1.37 KBwojtha
#3 openid_client_ax_notices.patch1.37 KBwojtha
openid_client_ax_shortname.patch2.17 KBwojtha
openid_ax_request.png102.32 KBwojtha

Comments

wojtha’s picture

wojtha commented
StatusFileSize
new openid_client_ax_notices.patch1.37 KB

Fixing three unitialized variable notices.

Edit: Aarrg... the patch is reversed. Check below.

wojtha’s picture

wojtha commented
StatusFileSize
new openid_client_ax_shortname.patch2.17 KB

Fixing three unitialized variable notices. (Once more and better...)

Edit: Wrong patch ...

wojtha’s picture

wojtha commented
StatusFileSize
new openid_client_ax_notices.patch1.37 KB

Oh man, I need more sleep... so now: Fixing three unitialized variable notices.

wojtha’s picture

wojtha commented
Title: Support AX extensions » Support AX extensions + namespace collision bug

#1055838: Namespace collision with short ax identifiers marked as duplicate of this issue.

It includes patch which doesn't introduce new function. However I prefer "my version" of the fix - the explicit name builder function, as it could be used in dependent modules or in other places of the module.

+ Changing the title to be more descriptive.

xamanu’s picture

xamanu commented
Version: 6.x-1.0-beta2 » 6.x-6.x-dev
StatusFileSize
new ax_extensions_avoiding_namespace_collision-1033292-5.patch3.53 KB

I just put your changes from both patches into one single patch. This might be easier for the module's maintainer to commit. Further I rerolled the patch based on the patch from #501702: Support update_url AX method to update profile data comment #7 since those had conflicts and support of update_url is way older and IMO really necessary.

xamanu’s picture

xamanu commented
StatusFileSize
new 1033292-6-openid_client_ax-ax_extensions.patch3.53 KB

With git diff it made some a/ and b/ directories on the files. Git apply works with this, but it's not working with drush make. So here is a new patch that should apply nicely.

xamanu’s picture

xamanu commented

I know of two modules that have to change on that:

* OpenID Profile: Newest commit depends on this patch here.
* OpenID CP Field: Patch available #1146326: Support AX extensions

xamanu’s picture

xamanu commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.