The call to drupal_redirect_form() is passing the URI of the desired redirect, instead of a $form_state array. I'm not sure whether we want to preserve the entire $form_state of the first form and pass that along, or just populate an array with a redirect key and send that. I'm guessing the former would be preferable. Patch forthcoming.

CommentFileSizeAuthor
#2 1033330-2-multiform-redirect.patch926 bytesksenzee
#1 1033330-1-multiform-redirect.patch745 bytesksenzee

Comments

ksenzee’s picture

ksenzee
she/her
commented
Status: Active » Needs review
StatusFileSize
new 1033330-1-multiform-redirect.patch745 bytes

This is still not perfect, because we have no way of knowing whether one of the forms would have set $form_state['no_redirect'] to TRUE, so we could be redirecting when we shouldn't be. But I think it's better than not redirecting at all.

ksenzee’s picture

ksenzee
she/her
commented
StatusFileSize
new 1033330-2-multiform-redirect.patch926 bytes

Oops - changed my patch and didn't retest it before posting. Bad ksenzee. Try this patch instead.

David_Rothstein’s picture

David_Rothstein commented
Status: Needs review » Fixed

Committed, with a code comment explaining why we explicitly have to unset the 'no_redirect' key (since I missed the fact that it was set above, until @ksenzee patiently explained it to me):

http://drupalcode.org/project/multiform.git/commit/ecaeb8b

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.