user_external_login_register creates notice/error in user_save [#1033912]

I'm using user_external_login_register() as part of an external authentication module. I'm passing it good information, but it's throwing the following notice;

Notice: Undefined index: mail in user_save() (line 567 of /modules/user/user.module).
The line it's calling is $edit['mail'] = trim($edit['mail']);

I noticed that user_external_login_register() does not pass 'mail' as part of the array to user_save(). Seems it may be easiest just to throw an IF statement around that line making sure the index 'mail' exists?

I apologize if I posted this in the wrong place, just something I noticed and wanted to bring to the community's attention.

Comment	File	Size	Author
#4	mail_fix.patch	542 bytes	divzero
#3	mail_fix.diff	542 bytes	divzero

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

accusoft CreditAttribution: accusoft commented 20 January 2011 at 14:22

as an update to this, I changed line 567 in users.module to:

if (isset($edit['mail']))
{
$edit['mail'] = trim($edit['mail']);
}

and it's working perfectly now.

My preference is not to "hack the core" so I would like more opinion on this.

Comment #2

daften CreditAttribution: daften commented 15 March 2011 at 17:19

Comment #3

divzero CreditAttribution: divzero commented 22 March 2011 at 07:33

File	Size
mail_fix.diff	542 bytes

I've created accudev's fix as a patch. Attached.

Comment #4

divzero CreditAttribution: divzero commented 22 March 2011 at 07:36

File	Size
mail_fix.patch	542 bytes

updated patch

Comment #5

divzero CreditAttribution: divzero commented 22 March 2011 at 07:39

Status:

Active

» Needs review

Comment #6

arosboro CreditAttribution: arosboro commented 24 March 2011 at 03:47

I just ran into this issue as well. Thanks for the patch.

Comment #7

arosboro CreditAttribution: arosboro commented 24 March 2011 at 15:46

I got a malformed error trying to use this patch on drupal 7 from the root directory

Comment #8

guybrush CreditAttribution: guybrush commented 30 March 2011 at 13:55

Priority:

Normal

» Major

This seems like a major issue, as it effectively renders the user_external_login_register() functionality useless. It seems that it is not possible to use this function for handling remote logins without a fix.