Closed (fixed)
Project:
Refine by taxonomy
Version:
4.7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
15 Dec 2006 at 09:24 UTC
Updated:
27 Jan 2007 at 09:30 UTC
Jump to comment: Most recent file
Comments
Comment #1
Bèr Kessels commentedacknowleged, thanks for the report.
Comment #2
mo6This quick patch doesn't show the block when no content is available.
Comment #3
Bèr Kessels commentedThis is not a really nice solution. As you state 'a quick fix'. Too quick to be committed just like this, though :)
I think we should simply make the theme function a tad smarter and tell it not to return empty ULs and LIs
Comment #4
mo6True, too quick perhaps. Here's a new patch which lets refine_by_taxo_build_body return an empty string when there's no content to display instead of an empty list. That's cleaner. Also, refine_by_taxo_view_blocks then shows the block only when there is content (no empty string) to display.
Comment #5
mo6In addition to the above patch, this patch also fixes a typo and cleans up the code a bit.
Comment #6
Bèr Kessels commentedComitted #4 in a slightly modified version to HEAD of this module.
I suggest you read http://drupal.org/node/318, the coding standards. Eventhough your style may be 'cleaner' for your own work, it violates about all the guidelines in Drupal :). For one, if () is ALWAYS accompanied by a {} in Drupal. We dont ever write } else { one one line, etceteras.
Comment #7
Bèr Kessels commented... bunt in any case: thank you for the patch and the hard work. It is much appreciated!
Comment #8
mo6#6 noted. Thanks, Bèr!
Comment #9
(not verified) commented