This patch updates the trackback module to 5.x.

CommentFileSizeAuthor
trackback.5x.patch.gz11.81 KBzorac

Comments

canadrian’s picture

Has anyone else tried out this patch? How does it work for you? I'm not in a huge rush for trackback until the Spam module is actually working, but eventually I would like to have trackback again.

Christoph C. Cemper’s picture

Zorac,

which cvs evision of trackback.module shall we apply this patch to?

I found these in the diff file,
and both don't match a revision date in CVS

--- trackback.orig/trackback.module 2006-06-14 02:00:12.000000000 +1000
+++ trackback/trackback.module 2006-12-15 18:02:14.884481600 +0900

I assume you applied changes to a version without my recent akismet integration?

Can you post your complete 5.x trackback.module, so I can take a look and possibly merge it with the current CVS version please

thanks
christoph

zorac’s picture

Oops,
Please apply this patch to "HEAD" revision on cvs,
and execute patch command with "-p1" option in the "trackback" directory.

> I assume you applied changes to a version without my recent akismet integration?

yes.

> Can you post your complete 5.x trackback.module, so I can take a look and possibly merge it with the current CVS version please

I think you can apply patch by the above way.

Regards,

Caerydd’s picture

I would like to test the patched version, but I have no clue as to how to go about patching a file. My knowledge of drupal is 'advanced admin' and 'newbie server admin', so I cannot use the patch. I would love to test drive/look for bugs on a current one though!

Ken Watts’s picture

I would also love to test a 5.x version with akismet integration. But from the discussion above, I can't figure out what to patch, or how. But I don't know if the CVS version has changed since the patch, or whether that version has akismet.

If someone could produce a test version, I would gladly install it on my 5.x test site and report back on any problems, or successes...

-Ken

zorac’s picture

Okey, I uploaded the complete trackback 5.x module to:

http://drupal-jbox.net/files/trackback5-patched.tar_.gz

Regards,

Ken Watts’s picture

Thanks,

I'll install it and report back.

brashquido’s picture

placeholder ;-)

denney’s picture

Thanks for the update. I'm gonna test it.

Ken Watts’s picture

I've installed it, and have two problems right at the start.

First, the administration-trackback link on the menu just gives me a white screen.

Second, the administration-settings-trackback link leads to a normal screen with the title "Trackback", and under that, "srackback_configure" (not my typo, that's exactly what it says--no quotes of course). The rest of the screen is blank.

I've opened the module and done a search on "srackback_configure" and turned up nothing, so I have no idea where it's coming from.

That's all I've got for now--I'll report back when I figure out more...

If anyone else has a clue, insights would be greatly appreciated.

Ken

bartmoss’s picture

The INSTALL.TXT says:

(3) There is a file called trackback.mysql. You need to
feed this to your mysql:

ON THE COMMAND-LINE
mysql -u user -p password < trackback.mysql

But there is no such file. The module seems to install fine anyway - testing now.

- RB

bartmoss’s picture

It seems to work for me, but only manually; i.e. autodiscovery of pingable URLs doesn't work; I have to manually specify the trackback url both when I ping another blog's posting, as well as if that other blog pings drupal. Used in conjuncture with wordpress as the other test site. I don't claim to know why this won't work, sorry; the xml bit in the drupal post seems to be okay.

Also, very importantly, moderation of trackbacks must be enabled by default; otherwise you will open up any default installation of this module vulnerable to trackback spam. And I don't think that is something we want...

- RB

Christoph C. Cemper’s picture

@bart: the mysql script shouldn't be required at all - the .install file should have set the tables

For anti-spam support you need integration with the spam module (which doesn't work good for me)
or akismet (which is not yet done for 5.x)

bartmoss’s picture

I was pointing out a discrepancy between the documentation and facts.

Also, I know Akismet and other anti-spam methods. Leaving trackbacks unmoderated it still a bad idea, unless the trackback module will be set to require one such anti-spam modules. If spammers can successfully distribute their junk, everybody loses. :-(

zorac’s picture

@Ken: by 5.x, the administration-trackback link is *NOT* provided on the menu. It moves to admin/content/trackback.

Christoph C. Cemper’s picture

@bart: sorry I missed the part with the default moderator settings. I agree with you

@zorac: do you agree? we should make tb moderation default enabled, ok?

zorac’s picture

@Christoph: umm, I think it is different issue from 5.x patch.

Christoph C. Cemper’s picture

Zorac, I've been testing this 5.x patch on my http://weblog.cemper.com
and found that despite the "allow trackbacks" is set to yes, all posts receive an unchecked flag when editing them...

seems to be some forms-api flaw, at least the checkmark isn't stored properly

bartmoss’s picture

I noticed that drupal doesn't have a rel="pingback" href in the header. Maybe this is interfering with the "autodiscovery" of trackbacks from wordpress?

zorac’s picture

@Christoph: yes, it is a reported bug. see http://drupal.org/node/45003

I didn't include this bug fix patch in 5.x patch, because it still need review.

widhalmt’s picture

I'm really looking forward to using trackback on 5.x, so I'm subscribing to this issue.

forngren’s picture

Also subscribing, I'm really interested in this.

dsamuel’s picture

I have a keen interest in this, so subscribing.
In my opinion, This module should be part of the core, like in WordPress.

wundo’s picture

Priority: Normal » Critical

Subscribing, also interested in this feature.

jpwillms’s picture

also interested and subscribing.

zorac’s picture

This patch was committed to CVS and released.
Thanks.

zorac’s picture

Status: Needs review » Fixed
Anonymous’s picture

Status: Fixed » Closed (fixed)