Two additions menu_link_load_multiple() and menu_link_delete_multiple().

They improve performance on install and _menu_navigation_links_rebuild(), menu_delete_links(), menu_link_delete() and system_get_module_admin_tasks()

CommentFileSizeAuthor
menu_link4.patch11.94 KBcasey

Comments

catch’s picture

catch
he/him
Primary language English
commented

Looks good.

I think this comment needs updating (looks like it also needed that prior to this patch as well):

+        ->execute()->fetchAllAssoc('mlid', PDO::FETCH_ASSOC);
       // Remove all such items. Starting from those with the greatest depth will
       // minimize the amount of re-parenting done by menu_link_delete().
-      foreach ($result as $item) {
-        _menu_delete_item($item, TRUE);
-      }
+      _menu_link_delete_multiple($items, TRUE);
casey’s picture

casey commented
Version: 7.x-dev » 8.x-dev
Issue tags: +API addition
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Related (kinda): #916388: Convert menu links into entities

thedavidmeister’s picture

thedavidmeister commented
Issue tags: -Performance, -API addition

menu_link4.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Performance, +API addition

The last submitted patch, menu_link4.patch, failed testing.

dcrocks’s picture

dcrocks commented

Isn't this done? The api's exist now.

thedavidmeister’s picture

thedavidmeister commented
Status: Needs work » Closed (duplicate)

sounds like it.