Warning: Parameter 1 to amazon_store_addcart_form() expected to be a reference, value given in drupal_retrieve_form() (line 771 of /home/ysadmin/public_html/includes/form.inc).

I am getting error and other similar ones like above with a fresh install of DP7 and Amazon Store. I am including a screenshot to show the other errors.

CommentFileSizeAuthor
#3 amazon_store_byreference.patch2.16 KBpancho
#2 error.jpg220.38 KBkrymp

Comments

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Title: amazon_store_addcart_form() » Warning: Parameter 1 to amazon_store_addcart_form() expected to be a reference

Didn't get the screenshot, would appreciate it. Also, please say exactly what action you took to get this message, and it would also help to know what other modules are installed.

krymp’s picture

krymp commented
StatusFileSize
new error.jpg220.38 KB

Sorry forgot to press the attach button. I get this in everyone of my Amazon Store pages. I also get it on my Item Detail page by using the default Amazon Panels template - http://yousketch.net/amazon_store/item/0596515804.

I have a few modules, Panels, Views, Media, Youtube-Media, StarRating and Styles

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Version: 7.x-1.0-beta1 » 7.x-1.x-dev
Priority: Normal » Major
Status: Active » Needs review
StatusFileSize
new amazon_store_byreference.patch2.16 KB

If you can't reproduce this error, this might have something to do with PHP 5.3.
I actually don't have a PHP 5.2 server running, however with PHP 5.3 I get the same errors.

Removing the ampersand from the first argument in the signature of the various forms helps here. The errors are gone and everything works just fine. Patch enclosed.

krymp’s picture

krymp commented

Thank you!!! This patch worked for me.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented

The patch is correct:
The new signature of callbacks called by drupal_get_form() doesn't require call $form by reference, and PHP 5.3 in fact doesn't like it.
See also #946302: Warning: Parameter 1 to ctools_export_ui_edit_item_wizard_form() expected to be a reference, value given in drupal_retrieve_form.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs review » Reviewed & tested by the community

I was just on crack when I updated those.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Status: Reviewed & tested by the community » Fixed

committed to D7: http://drupal.org/cvs?commit=490360

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Tafa’s picture

Tafa commented

not sure if this has been causing trouble to others but i found that installed the variable module solved the problem almost immediately. Just en passant..
T

Tafa’s picture

Tafa commented

okay, not working actually...opening a new issue to keep things separate...