Vertical tabs in node type form are wrong

Yes, I was about to post the same. There are three vertical tabs in the node-type admin edit form. The first two are 'publishing settings' and 'unpublishing settings' which have the correct content. The last one is 'scheduler' which is empty. Attached is a screen shot for the record.

Attaching a patch which at least gets the form items underneath "Scheduler settings". Marking as "needs work" since I think we'd rather have fieldsets, or at least separate out the publishing and unpublishing settings with headings.

Is this anything to do with #986298: fieldsets inside of vertical tabs on the form prepend "Show/Hide" to the titles that are displayed in the vertical tabs ?

With the patch to core that Eric just pointed out, try the attached patch to Scheduler 7.x dev (ignoring my patch above). It results in the screenshot also attached.

Without the patch to core, the Publishing Settings and Unpublishing Settings fieldsets will need to be uncollasped ('#collapsed' => FALSE), otherwise they won't show up. Even in that case, without the core patch, the titles of the fieldsets won't show up.

I would suggest that we have the best of both your ideas. We want to make it easy to revisit and fix this when #1015798: Fieldsets inside vertical tabs have no title and can't be collapsed is committed, but also we do not want to reduce the functionality of scheduler's nice fieldsets by forcing them open. We can do this by adding our own scheduer.css file which just contains the additions in that patch and we can simply remove them when they are in D7 core. We can write our form exactly how it should be done. We then retain the ability to set the collapsed true/false for our fieldsets etc.

The attached screen grabs show this fix for Bartik and Seven. The only slight trade-off is that the Seven css should not really be added to all themes, it makes a small bit of white space at the top of the fieldset in Bartik, but that is a small price to pay, and it will dissappear when we empty out the css when the D7 core is patched.

I have re-applied the formatting re-allignment that Eric did, but I almost didn't as it just confuses things and makes the patch look more complicated. But then I thought, Eric wanted it done in his patch, so I would not undo his work ;-)

It works fine in Garland and Stark too.

Do we need to add scheduler.css into the files 'array' in scheduler.info?

Also what about scheduler_handler_field_scheduler_countdown.inc and scheduler_vertical_tabs.js?
I've not read up on what should go into the new style of .info file.

Regarding those two files, would it not be better if they were scheduer. instead of scheduler_? Or this that specifically to make them different?

Thanks for the info. Excellent answers!

When was this committed?

I'm still running into this issue using 7.x.-1.0.

Please release 7x.-1.1 with this fix.

Hi fizk
This original fix does appear in 7.x-1.0 - the css file is present, and that was new with this. What theme are you using? This solution only addressed the core 7.x themes bartik, seven, garland and stark. Other themes may have been fixed by it, but they were not tested.

However, a later more comprehensive patch is in #1172040: Contrib solution for non-collapsible fieldsets and missing titles which has not been committed yet. This caters for all of the above, plus Rubik, and has the capacity for correcting any other specific themes more easily.

Jonathan

Until we know what theme you are using we can't help with any fix.

This is broken in Rubik.

Hey Duran,

That issue is has been resolved over here, just waiting for RTBC and commit: http://drupal.org/node/1172040#comment-6604870