Currently, this theme function only takes $url and $title parameters, respectively used as $url and part of the $options array for the l() call used inside.
However, the $options parameters to l() is hardcoded to ignore any extra options, which could be passed in: array('attributes' => array('title' => $variables['title']))).
This prevents using it with any URL containing options like a query or fragment. It should merge in options received, which would also have the advantage of making it directly usable with the url/options format returned by entity_uri(). Having $title, which is only part of these options, be a direct parameter to theme_more_link(), makes is not completely obvious, but the options merging could still be done.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | theme_more_link-1036190-5.patch | 1.4 KB | pbull |
| #3 | theme_more_link-1036190.patch | 1.18 KB | pbull |
| #1 | theme_1036190.patch | 1.49 KB | fgm |
Comments
Comment #1
fgmSuggested patch.
Comment #2
fgm#1: theme_1036190.patch queued for re-testing.
Comment #3
pbull commentedRe-rolled this patch in Git; removed the debugging lines from bootstrap.inc.
Comment #4
fgmThanks for rerolling, but you did not include the "options" part of the phpdoc, which I think is needed.
Comment #5
pbull commentedGood point, updated patch attached with phpdocs added.
Comment #6
droplet commentedWe started anther issue included accessibility: #1136680: #type 'more_link' - previously theme_more_link() - should have more context
if it doesn't backport, do you mind I close this one as #1136680 has more discuss. thanks.
Comment #7
fgmFollowing up on later issue #1136680: #type 'more_link' - previously theme_more_link() - should have more context.