Alternate mobile front page view not working in dev

hi bcobin,

I just committed the fix for the frontpage problem to the dev version! It was caused by my refactoring two weeks ago... You can get it from cvs or wait for the new dev build!

Tom

Hmmm... I see, it is indeed not working.
I fixed it by putting the configuration of the frontpage in hook_boot().

It should be ok now...

Hi there!

I'm trying Mobile Tools module (amazing work!) but the frontpage feature is not working at all: my mobile frontpage was never displayed, but I think I've found a workaround:

mobile_tools.module [line 150]:

  // Some small extras 
  if (mobile_tools_is_mobile_site() == 'mobile' || $theme_switched) {
    $conf['default_nodes_main'] = variable_get('default_nodes_main_mobile', variable_get('default_nodes_main', 10));
    $conf['site_frontpage'] = variable_get('site_frontpage_mobile', variable_get('site_frontpage', 'node'));
    $_GET['q'] = drupal_get_normal_path(variable_get('site_frontpage_mobile', variable_get('site_frontpage', 'node')));
  }

I took this line

$_GET['q'] = drupal_get_normal_path(variable_get('site_frontpage_mobile', variable_get('site_frontpage', 'node')));

from includes/path.inc and now the frontpage feature is working fine.

Hope this helps!

No, it's not a fix. This workaround causes a continuous redirect to the mobile home page, making navigation impossible.

Anyway, there should be a fix because it's not working at all.

Ok, I think I've found a new workaround:

  if (mobile_tools_is_mobile_site() == 'mobile' || $theme_switched) {
    $conf['default_nodes_main'] = variable_get('default_nodes_main_mobile', variable_get('default_nodes_main', 10));
    $conf['site_frontpage'] = variable_get('site_frontpage_mobile', variable_get('site_frontpage', 'node'));
    if (!empty($_GET['q'])) {
      if(drupal_is_front_page($_GET['q'])) {
        $_GET['q'] = drupal_get_normal_path($conf['site_frontpage']);
      } else {
        $_GET['q'] = drupal_get_normal_path(trim($_GET['q'], '/'));
      }
    }
    else {
      $_GET['q'] = drupal_get_normal_path($conf['site_frontpage']);
    }
  } 

Could you please validate this fix? I know it's not the best solution, but now it's working.

Thank you in advance!

The homepage problem should be fixed in the dev release and forcing a certain version of the site is replaced by the ?device= ... directive.

Closing this thread, unless somebody experiences problems (but maybe then a new thread can be started :))

Not fixed in 6.x-2.4

This fixes it under my current environment. Many apologies, no time to create a patch right now.

Change mobile_tools.module, line 225

from

if ($mobile_tools_device == 'mobile' and mobile_tools_site_type() == 'mobile') {

to

if ($mobile_tools_device['type'] == 'mobile' && mobile_tools_site_type() == 'mobile') {

#12 looks reasonable to me. A patch to implement the change.

Committed to 6.x-2.x.

Sorry, but it is still not working at me.

Using latest Drupal 6 and latest (non dev) mobile Tools 2.6.

My mobile Page screws up with endless redirection but not to the setted mobile-frontpage.

Any solutions or hints?

Update:
I just found out, when i activate automatic redirection with cookies, the whole redirection screws up in a loop.

Why?

I too was having problems with version 6.x-2.6 and solved it. I traced the issue to this line in mobile_tools_boot():

if ($mobile_tools_device['type'] == 'mobile' && mobile_tools_site_type() == 'mobile') {

The problem was now that mobile_tools_site_type() was never returning the correct value. The problem here appears to be that the entire mobile_tools_site_type() function as it is currently written is incorrect - it wants to load the module saved to the Drupal variable mobile-tools-site-type-detection, but no such value is ever saved in the module (or its admin pages).

The solution appears quite straightforward - the function to return whether or not the site visitor is on the mobile site is in mobile_tools.module itself as mobile_tools_is_mobile_site(). So, finally, simply replace the function mobile_tools_site_type() with:

/**
 * Determine the current site type.
 *
 * @return string
 *   A string, either 'desktop' or 'mobile', representing the current site type.
 */
function mobile_tools_site_type() {
  static $site_type;

  $site_type = mobile_tools_is_mobile_site();
  
  return $site_type;
}