Working on a D7 patch.

CommentFileSizeAuthor
#9 d7-upgrade-1036386-9.patch21.25 KBnedjo
#3 1036386-3-designkit-d7-upgrade.patch22.36 KBnedjo
#2 1036386-2-designkit-d7-upgrade.patch21.08 KBnedjo
#1 1036386-1-designkit-d7-upgrade.patch12.58 KBnedjo

Comments

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Active » Needs work
StatusFileSize
new 1036386-1-designkit-d7-upgrade.patch12.58 KB

Here's a first pass. Need to work more on upgrading colour picker and images.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 1036386-2-designkit-d7-upgrade.patch21.08 KB

Here's a fuller patch that seems to be working. See the changes to the README for what needs to be done to upgrade existing themes. Basically:

* Remove the <style> and </style> from style templates.
* In the theme's .info file, change the 'imagecache' property from e.g.
designkit[image][logo][imagecache] = "imagecache_scale:200x50"
to
designkit[image][logo][effect] = "image_scale:200x50"

Plus, obviously, make and CSS changes needed for the new Drupal version.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
StatusFileSize
new 1036386-3-designkit-d7-upgrade.patch22.36 KB

Page template of D6 is now divided between page and html templates. Implement both hook_preprocess_html() and hook_preprocess_page() to ensure that designkit variables are passed to both templates.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Needs review » Needs work

Image file deletion not working yet.

ranm’s picture

ranm commented

Thanks for this

mrsinguyen’s picture

mrsinguyen commented

Subcribe

drupa11y’s picture

drupa11y commented

Subscribe

rodych’s picture

rodych commented

+1

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new d7-upgrade-1036386-9.patch21.25 KB

Fixed the file deletion error (needed to pass full file object to file_delete()).

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

Posted a sandbox project with an upgraded Designkit at http://drupal.org/sandbox/nedjo/1289398.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented

Perhaps time to report this module as abandoned so that another maintainer can commit this work?

oliver huynh’s picture

oliver huynh commented

Yes, agree with jhedstrom.
@nedjo: What do you think? Can you port this out as a separate module?

kharbat’s picture

kharbat commented

Hi there, any clue when is the D7 patch gonna be released.. i tested it and i think it works just fine..

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

Posted issue #1540324: Offer to maintain Designkit.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Needs review » Fixed

Thanks yhahn for assigning me commit access. Applied the D7 upgrade, posted a 7.x-1.0-beta1 release, and updated the project page with D7 examples and dependency info.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.