These two, too!

CommentFileSizeAuthor
#2 1036436-ab-1.patch2.12 KBalanburke

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Version: 6.x-1.x-dev » 7.x-2.x-dev
alanburke’s picture

alanburke commented
Status: Active » Needs review
StatusFileSize
new 1036436-ab-1.patch2.12 KB

A start at this one.
Some debateable choices.
I'm particularly happy that I've found a legit use for the <mark> element.

mason@thecodingdesigner.com’s picture

mason@thecodingdesigner.com commented

comment-wrapper.tpl.php
we're embracing the new outlines so I'm using an h1 in comments wrapper.

comment.tpl.php
We're wrapping $picture in HEADER in node.tpl.php so I'm doing the same here.
Nice use of MARK. :)
Since I used an h1 in content-wrapper I changed the title here to an h2
I think the $signature is more appropriately placed in a FOOTER tag.
We're wrapping links in a FOOTER tag on node.tpl.php so I am here as well

I went ahead and committed these changes. Leaving this marked as "needs review" for now in case anyone wants to change it.